[GitHub] [spark] maropu commented on pull request #29126: [SPARK-32324][SQL]Fix error messages during using PIVOT and lateral view

2020-07-16 Thread GitBox
maropu commented on pull request #29126: URL: https://github.com/apache/spark/pull/29126#issuecomment-659770291 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] maropu commented on pull request #29126: [SPARK-32324][SQL]Fix error messages during using PIVOT and lateral view

2020-07-16 Thread GitBox
maropu commented on pull request #29126: URL: https://github.com/apache/spark/pull/29126#issuecomment-659407047 > we may make it more clear in SqlBase.g4 Any idea for that? I personally that the message update this PR proposes looks okay now.

[GitHub] [spark] maropu commented on pull request #29126: [SPARK-32324][SQL]Fix error messages during using PIVOT and lateral view

2020-07-16 Thread GitBox
maropu commented on pull request #29126: URL: https://github.com/apache/spark/pull/29126#issuecomment-659378822 I don't dig into it though, probably the second case is matched in `querySpecification`:

[GitHub] [spark] maropu commented on pull request #29126: [SPARK-32324][SQL]Fix error messages during using PIVOT and lateral view

2020-07-16 Thread GitBox
maropu commented on pull request #29126: URL: https://github.com/apache/spark/pull/29126#issuecomment-659356390 > We have the following defined in spark/sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4. but it seems pivotClause and lateralView need to replace

[GitHub] [spark] maropu commented on pull request #29126: [SPARK-32324][SQL]Fix error messages during using PIVOT and lateral view

2020-07-16 Thread GitBox
maropu commented on pull request #29126: URL: https://github.com/apache/spark/pull/29126#issuecomment-659222596 The mssage update itself seems okay; cc: @maryannxue @gatorsmile cuz I checked the original PR for `PIVOT`: https://github.com/apache/spark/pull/21187

[GitHub] [spark] maropu commented on pull request #29126: [SPARK-32324][SQL]Fix error messages during using PIVOT and lateral view

2020-07-15 Thread GitBox
maropu commented on pull request #29126: URL: https://github.com/apache/spark/pull/29126#issuecomment-659103736 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to