[GitHub] [spark] maropu commented on pull request #29585: [SPARK-32741][SQL] Check if the same ExprId refers to the unique attribute in logical plans

2020-10-01 Thread GitBox
maropu commented on pull request #29585: URL: https://github.com/apache/spark/pull/29585#issuecomment-702462503 Oh, I see and I didn't notice that. Thanks, @dongjoon-hyun ! I will check it now. If its better to revert it first, please let me know.

[GitHub] [spark] maropu commented on pull request #29585: [SPARK-32741][SQL] Check if the same ExprId refers to the unique attribute in logical plans

2020-09-30 Thread GitBox
maropu commented on pull request #29585: URL: https://github.com/apache/spark/pull/29585#issuecomment-701363018 Thanks! Merged to master. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] maropu commented on pull request #29585: [SPARK-32741][SQL] Check if the same ExprId refers to the unique attribute in logical plans

2020-09-29 Thread GitBox
maropu commented on pull request #29585: URL: https://github.com/apache/spark/pull/29585#issuecomment-700733819 Thanks for the review, @cloud-fan ! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] maropu commented on pull request #29585: [SPARK-32741][SQL] Check if the same ExprId refers to the unique attribute in logical plans

2020-09-29 Thread GitBox
maropu commented on pull request #29585: URL: https://github.com/apache/spark/pull/29585#issuecomment-700535884 @cloud-fan @viirya could you check this again? This is an automated message from the Apache Git Service. To

[GitHub] [spark] maropu commented on pull request #29585: [SPARK-32741][SQL] Check if the same ExprId refers to the unique attribute in logical plans

2020-09-16 Thread GitBox
maropu commented on pull request #29585: URL: https://github.com/apache/spark/pull/29585#issuecomment-693232942 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] maropu commented on pull request #29585: [SPARK-32741][SQL] Check if the same ExprId refers to the unique attribute in logical plans

2020-09-15 Thread GitBox
maropu commented on pull request #29585: URL: https://github.com/apache/spark/pull/29585#issuecomment-693134164 Could you check this again? @cloud-fan @viirya This is an automated message from the Apache Git Service. To

[GitHub] [spark] maropu commented on pull request #29585: [SPARK-32741][SQL] Check if the same ExprId refers to the unique attribute in logical plans

2020-09-15 Thread GitBox
maropu commented on pull request #29585: URL: https://github.com/apache/spark/pull/29585#issuecomment-693134219 retest this please This is an automated message from the Apache Git Service. To respond to the message, please