mundaym commented on pull request #29762:
URL: https://github.com/apache/spark/pull/29762#issuecomment-696404313
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
mundaym commented on pull request #29762:
URL: https://github.com/apache/spark/pull/29762#issuecomment-696786519
> While I see the caller of hashUnsafeWords(), I am not sure what hash value
is expected.
It's a good question. Right now the only users of `hashUnsafeWords` appear
to
mundaym commented on pull request #29762:
URL: https://github.com/apache/spark/pull/29762#issuecomment-696404313
> I expect to provide additional tests. Regarding the condition, it is nice
to have with me.
Added some basic test coverage to hashUnsafeWords.
mundaym commented on pull request #29762:
URL: https://github.com/apache/spark/pull/29762#issuecomment-696404313
> I expect to provide additional tests. Regarding the condition, it is nice
to have with me.
Added some basic test coverage to hashUnsafeWords.
mundaym commented on pull request #29762:
URL: https://github.com/apache/spark/pull/29762#issuecomment-693368436
Thanks, it sounds like the inline code that this PR uses is preferred to
Platform class changes at this point so I'll leave this PR as-is.
It might be worth reassessing
mundaym commented on pull request #29762:
URL: https://github.com/apache/spark/pull/29762#issuecomment-693262630
In an ideal world we'd probably consolidate platform endianness handling
into the Platform class by adding methods that perform the necessary
conversions. I'm not sure if that
