[GitHub] [spark] pan3793 commented on a diff in pull request #41062: [SPARK-43313][SQL][FOLLOWUP] Improvement for DSv2 API SupportsCustomSchemaWrite

2023-05-18 Thread via GitHub
pan3793 commented on code in PR #41062: URL: https://github.com/apache/spark/pull/41062#discussion_r1197682260 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/write/SupportsCustomSchemaWrite.java: ## @@ -18,21 +18,22 @@ package

[GitHub] [spark] pan3793 commented on a diff in pull request #41062: [SPARK-43313][SQL][FOLLOWUP] Improvement for DSv2 API SupportsCustomSchemaWrite

2023-05-18 Thread via GitHub
pan3793 commented on code in PR #41062: URL: https://github.com/apache/spark/pull/41062#discussion_r1197682260 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/write/SupportsCustomSchemaWrite.java: ## @@ -18,21 +18,22 @@ package

[GitHub] [spark] pan3793 commented on a diff in pull request #41062: [SPARK-43313][SQL][FOLLOWUP] Improvement for DSv2 API SupportsCustomSchemaWrite

2023-05-09 Thread via GitHub
pan3793 commented on code in PR #41062: URL: https://github.com/apache/spark/pull/41062#discussion_r1188666027 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/write/SupportsCustomSchemaWrite.java: ## @@ -27,12 +28,12 @@ * @since 3.4.1 */ @Evolving -public

[GitHub] [spark] pan3793 commented on a diff in pull request #41062: [SPARK-43313][SQL][FOLLOWUP] Improvement for DSv2 API SupportsCustomSchemaWrite

2023-05-05 Thread via GitHub
pan3793 commented on code in PR #41062: URL: https://github.com/apache/spark/pull/41062#discussion_r1186140005 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/write/SupportsCustomSchemaWrite.java: ## @@ -27,12 +28,12 @@ * @since 3.4.1 */ @Evolving -public