[GitHub] [spark] peter-toth commented on pull request #37319: [SPARK-39887][SQL] `PullOutGroupingExpressions` should generate different alias names

peter-toth commented on PR #37319: URL: https://github.com/apache/spark/pull/37319#issuecomment-1198525757 I've opened a PR with my proposal here: https://github.com/apache/spark/pull/37334 -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [spark] peter-toth commented on pull request #37319: [SPARK-39887][SQL] `PullOutGroupingExpressions` should generate different alias names

peter-toth commented on PR #37319: URL: https://github.com/apache/spark/pull/37319#issuecomment-1198030620 I don't think that extra `Alias` does any harm in that test, just the expected needs to be amended. My proposal also fixes the issue of the following: ``` SELECT a, b

[GitHub] [spark] peter-toth commented on pull request #37319: [SPARK-39887][SQL] `PullOutGroupingExpressions` should generate different alias names

peter-toth commented on PR #37319: URL: https://github.com/apache/spark/pull/37319#issuecomment-1197915164 So, I was thinking about adding ``` case _: Union => var first = true plan.mapChildren { child => if (first) { first =

[GitHub] [spark] peter-toth commented on pull request #37319: [SPARK-39887][SQL] `PullOutGroupingExpressions` should generate different alias names

peter-toth commented on PR #37319: URL: https://github.com/apache/spark/pull/37319#issuecomment-1197303315 Thanks for pinging me @cfmcgrady. I see the issue, but this looks more like a bug in `RemoveRedundantAliases` to me. -- This is an automated message from the Apache Git Service.