[GitHub] [spark] rdblue commented on a change in pull request #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2

2019-08-13 Thread GitBox
rdblue commented on a change in pull request #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2 URL: https://github.com/apache/spark/pull/25115#discussion_r313512216 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceResolution.scala

[GitHub] [spark] rdblue commented on a change in pull request #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2

2019-08-13 Thread GitBox
rdblue commented on a change in pull request #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2 URL: https://github.com/apache/spark/pull/25115#discussion_r313502253 ## File path: sql/core/src/test/scala/org/apache/spark/sql/sources/v2/DataSourceV2SQLSuite.scala ##

[GitHub] [spark] rdblue commented on a change in pull request #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2

2019-08-12 Thread GitBox
rdblue commented on a change in pull request #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2 URL: https://github.com/apache/spark/pull/25115#discussion_r313064739 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceResolution.scala

[GitHub] [spark] rdblue commented on a change in pull request #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2

2019-08-12 Thread GitBox
rdblue commented on a change in pull request #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2 URL: https://github.com/apache/spark/pull/25115#discussion_r313064244 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceResolution.scala

[GitHub] [spark] rdblue commented on a change in pull request #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2

2019-08-12 Thread GitBox
rdblue commented on a change in pull request #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2 URL: https://github.com/apache/spark/pull/25115#discussion_r313062070 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ##

[GitHub] [spark] rdblue commented on a change in pull request #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2

2019-08-01 Thread GitBox
rdblue commented on a change in pull request #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2 URL: https://github.com/apache/spark/pull/25115#discussion_r309798695 ## File path: sql/core/src/test/scala/org/apache/spark/sql/sources/v2/TestInMemoryTableCatalog.scala ##

[GitHub] [spark] rdblue commented on a change in pull request #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2

2019-08-01 Thread GitBox
rdblue commented on a change in pull request #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2 URL: https://github.com/apache/spark/pull/25115#discussion_r309798441 ## File path: sql/core/src/test/scala/org/apache/spark/sql/sources/v2/TestInMemoryTableCatalog.scala ##

[GitHub] [spark] rdblue commented on a change in pull request #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2

2019-08-01 Thread GitBox
rdblue commented on a change in pull request #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2 URL: https://github.com/apache/spark/pull/25115#discussion_r309798092 ## File path: sql/core/src/test/scala/org/apache/spark/sql/sources/v2/TestInMemoryTableCatalog.scala ##

[GitHub] [spark] rdblue commented on a change in pull request #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2

2019-08-01 Thread GitBox
rdblue commented on a change in pull request #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2 URL: https://github.com/apache/spark/pull/25115#discussion_r309796800 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2WriteSupportCheck.scal

[GitHub] [spark] rdblue commented on a change in pull request #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2

2019-08-01 Thread GitBox
rdblue commented on a change in pull request #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2 URL: https://github.com/apache/spark/pull/25115#discussion_r309796188 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceResolution.scala

[GitHub] [spark] rdblue commented on a change in pull request #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2

2019-08-01 Thread GitBox
rdblue commented on a change in pull request #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2 URL: https://github.com/apache/spark/pull/25115#discussion_r309794356 ## File path: sql/catalyst/src/main/java/org/apache/spark/sql/sources/v2/SupportsDelete.java ## @@

[GitHub] [spark] rdblue commented on a change in pull request #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2

2019-07-29 Thread GitBox
rdblue commented on a change in pull request #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2 URL: https://github.com/apache/spark/pull/25115#discussion_r308333464 ## File path: sql/core/src/test/scala/org/apache/spark/sql/sources/v2/TestInMemoryTableCatalog.scala ##

[GitHub] [spark] rdblue commented on a change in pull request #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2

2019-07-29 Thread GitBox
rdblue commented on a change in pull request #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2 URL: https://github.com/apache/spark/pull/25115#discussion_r308332025 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/sources/filters.scala ## @@ -36,10

[GitHub] [spark] rdblue commented on a change in pull request #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2

2019-07-29 Thread GitBox
rdblue commented on a change in pull request #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2 URL: https://github.com/apache/spark/pull/25115#discussion_r308331696 ## File path: sql/catalyst/src/main/java/org/apache/spark/sql/sources/v2/SupportsDelete.java ## @@

[GitHub] [spark] rdblue commented on a change in pull request #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2

2019-07-29 Thread GitBox
rdblue commented on a change in pull request #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2 URL: https://github.com/apache/spark/pull/25115#discussion_r308331238 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala ##

[GitHub] [spark] rdblue commented on a change in pull request #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2

2019-07-29 Thread GitBox
rdblue commented on a change in pull request #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2 URL: https://github.com/apache/spark/pull/25115#discussion_r308330077 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceResolution.scala

[GitHub] [spark] rdblue commented on a change in pull request #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2

2019-07-29 Thread GitBox
rdblue commented on a change in pull request #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2 URL: https://github.com/apache/spark/pull/25115#discussion_r308330162 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala #