[GitHub] [spark] rdblue commented on issue #24233: [SPARK-26356][SQL] remove SaveMode from data source v2

2019-05-23 Thread GitBox
rdblue commented on issue #24233: [SPARK-26356][SQL] remove SaveMode from data source v2 URL: https://github.com/apache/spark/pull/24233#issuecomment-495283737 @cloud-fan, thanks for fixing the issue. I think this is ready to go. +1 from me.

[GitHub] [spark] rdblue commented on issue #24233: [SPARK-26356][SQL] remove SaveMode from data source v2

2019-05-23 Thread GitBox
rdblue commented on issue #24233: [SPARK-26356][SQL] remove SaveMode from data source v2 URL: https://github.com/apache/spark/pull/24233#issuecomment-495268411 @cloud-fan, I don't think that issue is accurate. The problem is that there is a hack to continue passing SaveMode into some

[GitHub] [spark] rdblue commented on issue #24233: [SPARK-26356][SQL] remove SaveMode from data source v2

2019-05-22 Thread GitBox
rdblue commented on issue #24233: [SPARK-26356][SQL] remove SaveMode from data source v2 URL: https://github.com/apache/spark/pull/24233#issuecomment-495037807 @cloud-fan, I don't recall that conclusion from a sync. Can you quote from the notes that you're talking about? I'm fine