[GitHub] [spark] rxin commented on a change in pull request #28901: [SPARK-32064][SQL] Supporting create temporary table
rxin commented on a change in pull request #28901:
URL: https://github.com/apache/spark/pull/28901#discussion_r449984452
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/StaticSQLConf.scala
##
@@ -226,4 +227,22 @@ object StaticSQLConf {
.version("3.0.0")
.intConf
.createWithDefault(100)
+
+ val SPARK_SCRATCH_DIR =
+buildStaticConf("spark.scratchdir")
+ .doc("Scratch space for Spark temporary table and so on. Similar with
hive.exec.scratchdir")
Review comment:
let's not bring up hive here. Slowly nobody will care about Hive.
Also this should be spark.sql.scratchdir?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] rxin commented on a change in pull request #28901: [SPARK-32064][SQL] Supporting create temporary table
rxin commented on a change in pull request #28901:
URL: https://github.com/apache/spark/pull/28901#discussion_r449984265
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
##
@@ -3030,6 +3031,215 @@ abstract class DDLSuite extends QueryTest with
SQLTestUtils {
}
}
}
+
+ test("create temporary table using data source") {
Review comment:
maybe create a new suite for these?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
