[GitHub] [spark] sarutak commented on a change in pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline

[GitBox]

sarutak commented on a change in pull request #28803:
URL: https://github.com/apache/spark/pull/28803#discussion_r451282622



##
File path: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala
##
@@ -184,20 +188,52 @@ private[ui] class AllJobsPage(parent: JobsTab, store: 
AppStatusStore) extends We
 val eventArrayAsStr =
   (jobEventJsonAsStrSeq ++ executorEventJsonAsStrSeq).mkString("[", ",", 
"]")
 
-
-  
-  
-Event Timeline
-  
- ++
-
-  
-
-  
-  Enable zooming
+if (totalPages > 0) {
+  
+
+
+  Event Timeline
+
+   ++
+
+  
+
+  
+  Enable zooming
+
+
+  
+Jobs:
+  {totalJobs}
+  .
+  {totalPages}
+  Pages. Jump to
+

[GitHub] [spark] sarutak commented on a change in pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline

[GitBox]

sarutak commented on a change in pull request #28803:
URL: https://github.com/apache/spark/pull/28803#discussion_r451282321



##
File path: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala
##
@@ -184,20 +188,52 @@ private[ui] class AllJobsPage(parent: JobsTab, store: 
AppStatusStore) extends We
 val eventArrayAsStr =
   (jobEventJsonAsStrSeq ++ executorEventJsonAsStrSeq).mkString("[", ",", 
"]")
 
-
-  
-  
-Event Timeline
-  
- ++
-
-  
-
-  
-  Enable zooming
+if (totalPages > 0) {
+  
+
+
+  Event Timeline
+
+   ++
+
+  
+
+  
+  Enable zooming
+
+
+  

Review comment:
   Thanks. I'll consider it.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org