[GitHub] [spark] skonto commented on issue #24613: [SPARK-27549][SS] Add support for committing kafka offsets per batch for supporting external tooling

2019-05-31 Thread GitBox
skonto commented on issue #24613: [SPARK-27549][SS] Add support for committing kafka offsets per batch for supporting external tooling URL: https://github.com/apache/spark/pull/24613#issuecomment-497625796 @dongjoon-hyun I do respect other people's opinions, it is not the first time

[GitHub] [spark] skonto commented on issue #24613: [SPARK-27549][SS] Add support for committing kafka offsets per batch for supporting external tooling

2019-05-26 Thread GitBox
skonto commented on issue #24613: [SPARK-27549][SS] Add support for committing kafka offsets per batch for supporting external tooling URL: https://github.com/apache/spark/pull/24613#issuecomment-496030795 @dongjoon-hyun Do you also think that the code base is too large so adding a few

[GitHub] [spark] skonto commented on issue #24613: [SPARK-27549][SS] Add support for committing kafka offsets per batch for supporting external tooling

2019-05-22 Thread GitBox
skonto commented on issue #24613: [SPARK-27549][SS] Add support for committing kafka offsets per batch for supporting external tooling URL: https://github.com/apache/spark/pull/24613#issuecomment-494772544 @dongjoon-hyun what is your call?

[GitHub] [spark] skonto commented on issue #24613: [SPARK-27549][SS] Add support for committing kafka offsets per batch for supporting external tooling

2019-05-21 Thread GitBox
skonto commented on issue #24613: [SPARK-27549][SS] Add support for committing kafka offsets per batch for supporting external tooling URL: https://github.com/apache/spark/pull/24613#issuecomment-494550083 > Spark already has a large code base. Since this can be done easily inside a

[GitHub] [spark] skonto commented on issue #24613: [SPARK-27549][SS] Add support for committing kafka offsets per batch for supporting external tooling

2019-05-21 Thread GitBox
skonto commented on issue #24613: [SPARK-27549][SS] Add support for committing kafka offsets per batch for supporting external tooling URL: https://github.com/apache/spark/pull/24613#issuecomment-494520497 @zsxwing > The inconsistency between Spark's checkpoint and Kafka commit

[GitHub] [spark] skonto commented on issue #24613: [SPARK-27549][SS] Add support for committing kafka offsets per batch for supporting external tooling

2019-05-21 Thread GitBox
skonto commented on issue #24613: [SPARK-27549][SS] Add support for committing kafka offsets per batch for supporting external tooling URL: https://github.com/apache/spark/pull/24613#issuecomment-494326600 > That is also right but then we need to warn it for commitOffsetsOnCheckpoints

[GitHub] [spark] skonto commented on issue #24613: [SPARK-27549][SS] Add support for committing kafka offsets per batch for supporting external tooling

2019-05-21 Thread GitBox
skonto commented on issue #24613: [SPARK-27549][SS] Add support for committing kafka offsets per batch for supporting external tooling URL: https://github.com/apache/spark/pull/24613#issuecomment-494324725 I understand the danger it is the same danger as with `kafka.group.id` but I was

[GitHub] [spark] skonto commented on issue #24613: [SPARK-27549][SS] Add support for committing kafka offsets per batch for supporting external tooling

2019-05-21 Thread GitBox
skonto commented on issue #24613: [SPARK-27549][SS] Add support for committing kafka offsets per batch for supporting external tooling URL: https://github.com/apache/spark/pull/24613#issuecomment-494320693 > One thing we can imagine is running multiple queries in same application -

[GitHub] [spark] skonto commented on issue #24613: [SPARK-27549][SS] Add support for committing kafka offsets per batch for supporting external tooling

2019-05-21 Thread GitBox
skonto commented on issue #24613: [SPARK-27549][SS] Add support for committing kafka offsets per batch for supporting external tooling URL: https://github.com/apache/spark/pull/24613#issuecomment-494313373 > Something like monitoringGroupId Using the source options affects all the

[GitHub] [spark] skonto commented on issue #24613: [SPARK-27549][SS] Add support for committing kafka offsets per batch for supporting external tooling

2019-05-20 Thread GitBox
skonto commented on issue #24613: [SPARK-27549][SS] Add support for committing kafka offsets per batch for supporting external tooling URL: https://github.com/apache/spark/pull/24613#issuecomment-494092510 @gaborgsomogyi @HeartSaVioR what if I introduce queryOptions at the `query.start()`

[GitHub] [spark] skonto commented on issue #24613: [SPARK-27549][SS] Add support for committing kafka offsets per batch for supporting external tooling

2019-05-20 Thread GitBox
skonto commented on issue #24613: [SPARK-27549][SS] Add support for committing kafka offsets per batch for supporting external tooling URL: https://github.com/apache/spark/pull/24613#issuecomment-493974211 > Why not use one group and listConsumerGroupOffsets? @gaborgsomogyi yes

[GitHub] [spark] skonto commented on issue #24613: [SPARK-27549][SS] Add support for committing kafka offsets per batch for supporting external tooling

2019-05-20 Thread GitBox
skonto commented on issue #24613: [SPARK-27549][SS] Add support for committing kafka offsets per batch for supporting external tooling URL: https://github.com/apache/spark/pull/24613#issuecomment-493964039 I will update the PR shortly addressing all above comments, already have

[GitHub] [spark] skonto commented on issue #24613: [SPARK-27549][SS] Add support for committing kafka offsets per batch for supporting external tooling

2019-05-20 Thread GitBox
skonto commented on issue #24613: [SPARK-27549][SS] Add support for committing kafka offsets per batch for supporting external tooling URL: https://github.com/apache/spark/pull/24613#issuecomment-493961670 @gaborgsomogyi > A high level design question.

[GitHub] [spark] skonto commented on issue #24613: [SPARK-27549][SS] Add support for committing kafka offsets per batch for supporting external tooling

2019-05-15 Thread GitBox
skonto commented on issue #24613: [SPARK-27549][SS] Add support for committing kafka offsets per batch for supporting external tooling URL: https://github.com/apache/spark/pull/24613#issuecomment-492806050 @arunmahadevan I havent tried it but I know commits can be [out of

[GitHub] [spark] skonto commented on issue #24613: [SPARK-27549][SS] Add support for committing kafka offsets per batch for supporting external tooling

2019-05-15 Thread GitBox
skonto commented on issue #24613: [SPARK-27549][SS] Add support for committing kafka offsets per batch for supporting external tooling URL: https://github.com/apache/spark/pull/24613#issuecomment-492766741 @arunmahadevan regarding the other issue about the failing batch I think since the

[GitHub] [spark] skonto commented on issue #24613: [SPARK-27549][SS] Add support for committing kafka offsets per batch for supporting external tooling

2019-05-15 Thread GitBox
skonto commented on issue #24613: [SPARK-27549][SS] Add support for committing kafka offsets per batch for supporting external tooling URL: https://github.com/apache/spark/pull/24613#issuecomment-492733735 @arunmahadevan yes we have thought of this, my colleague @seglo has created a tool

[GitHub] [spark] skonto commented on issue #24613: [SPARK-27549][SS] Add support for committing kafka offsets per batch for supporting external tooling

2019-05-15 Thread GitBox
skonto commented on issue #24613: [SPARK-27549][SS] Add support for committing kafka offsets per batch for supporting external tooling URL: https://github.com/apache/spark/pull/24613#issuecomment-492616494 @gaborgsomogyi thanks, havent faced any issues. I will check if I can add unit