[GitHub] [spark] srielau commented on a diff in pull request #41007: [WIP][SPARK-43205] IDENTIFIER clause

srielau commented on code in PR #41007: URL: https://github.com/apache/spark/pull/41007#discussion_r1195640676 ## sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4: ## @@ -434,17 +434,31 @@ resource dmlStatementNoWith : insertInto query

[GitHub] [spark] srielau commented on a diff in pull request #41007: [WIP][SPARK-43205] IDENTIFIER clause

srielau commented on code in PR #41007: URL: https://github.com/apache/spark/pull/41007#discussion_r1194542884 ## sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4: ## @@ -907,6 +922,7 @@ primaryExpression | qualifiedName DOT ASTERISK

[GitHub] [spark] srielau commented on a diff in pull request #41007: [WIP][SPARK-43205] IDENTIFIER clause

srielau commented on code in PR #41007: URL: https://github.com/apache/spark/pull/41007#discussion_r1194542495 ## sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4: ## @@ -434,17 +434,31 @@ resource dmlStatementNoWith : insertInto query

[GitHub] [spark] srielau commented on a diff in pull request #41007: [WIP][SPARK-43205] IDENTIFIER clause

srielau commented on code in PR #41007: URL: https://github.com/apache/spark/pull/41007#discussion_r1194386802 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala: ## @@ -276,6 +279,138 @@ object UnresolvedAttribute { } } +/** + * Holds

[GitHub] [spark] srielau commented on a diff in pull request #41007: [WIP][SPARK-43205] IDENTIFIER clause

srielau commented on code in PR #41007: URL: https://github.com/apache/spark/pull/41007#discussion_r1194384090 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala: ## @@ -276,6 +279,138 @@ object UnresolvedAttribute { } } +/** + * Holds

[GitHub] [spark] srielau commented on a diff in pull request #41007: [WIP][SPARK-43205] IDENTIFIER clause

srielau commented on code in PR #41007: URL: https://github.com/apache/spark/pull/41007#discussion_r1194380150 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala: ## @@ -276,6 +279,138 @@ object UnresolvedAttribute { } } +/** + * Holds

[GitHub] [spark] srielau commented on a diff in pull request #41007: [WIP][SPARK-43205] IDENTIFIER clause

srielau commented on code in PR #41007: URL: https://github.com/apache/spark/pull/41007#discussion_r1194379328 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/IdentifierClauseUtil.scala: ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software

[GitHub] [spark] srielau commented on a diff in pull request #41007: [WIP][SPARK-43205] IDENTIFIER clause

srielau commented on code in PR #41007: URL: https://github.com/apache/spark/pull/41007#discussion_r1194378050 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala: ## @@ -2108,6 +2123,18 @@ class Analyzer(override val catalogManager: