srowen commented on a change in pull request #28657:
URL: https://github.com/apache/spark/pull/28657#discussion_r432462642
##########
File path: project/MimaExcludes.scala
##########
@@ -45,7 +45,11 @@ object MimaExcludes {
// after: class ChiSqSelector extends PSelector
// false positive, no binary incompatibility
ProblemFilters.exclude[MissingTypesProblem]("org.apache.spark.ml.feature.ChiSqSelectorModel"),
-
ProblemFilters.exclude[MissingTypesProblem]("org.apache.spark.ml.feature.ChiSqSelector")
+
ProblemFilters.exclude[MissingTypesProblem]("org.apache.spark.ml.feature.ChiSqSelector"),
+
+ //[SPARK-31840] Add instance weight support in LogisticRegressionSummary
+ // weightCol in
org.apache.spark.ml.classification.LogisticRegressionSummary is present only in
current version
+
ProblemFilters.exclude[ReversedMissingMethodProblem]("org.apache.spark.ml.classification.LogisticRegressionSummary.weightCol")
Review comment:
Looks fine, that's a sealed trait anyway
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
