srowen commented on issue #24884: [SPARK-28066][CORE] Optimize UTF8String.trim() for common case of no whitespace URL: https://github.com/apache/spark/pull/24884#issuecomment-502685764 Do we want to describe the implementation in the docs? the caller doesn't necessarily care or need to know about that implementation detail. Granted this is an internal class anyway, but developers looking at the 'internal' javadoc are already looking at the source. Here I said "string" rather than `UTF8String` to indicate it's the logical contents of this string with modifications. BTW the "10%" just referred to my crude benchmark. There's no way to know how many strings will be passed that need trimming, though probably few do.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
