[GitHub] [spark] srowen commented on pull request #37738: add Support Java Class with circular references

2023-03-17 Thread via GitHub
srowen commented on PR #37738: URL: https://github.com/apache/spark/pull/37738#issuecomment-1473647828 Still seems weird to me -- Does this happen to even be 'enough' for the protobuf case? Or does this extra unwanted descriptor field add other unneeded cols? Is it 'too much' - Is it

[GitHub] [spark] srowen commented on pull request #37738: add Support Java Class with circular references

2022-08-31 Thread GitBox
srowen commented on PR #37738: URL: https://github.com/apache/spark/pull/37738#issuecomment-1233698787 Can you describe a valid use case? I can't think of one. Encoders are used with data classes, bean-like classes -- This is an automated message from the Apache Git Service. To respond

[GitHub] [spark] srowen commented on pull request #37738: add Support Java Class with circular references

2022-08-31 Thread GitBox
srowen commented on PR #37738: URL: https://github.com/apache/spark/pull/37738#issuecomment-1233183779 Hm, skipping them doesn't seem right either. Not sure if this should be an option; it is just something that doesn't make sense to encode -- This is an automated message from the Apache