ueshin edited a comment on issue #24073: [SPARK-27134][SQL] array_distinct 
function does not work correctly with columns containing array of array
URL: https://github.com/apache/spark/pull/24073#issuecomment-473164953
 
 
   ~LGTM.~
   I rethought after 
https://github.com/apache/spark/pull/24073#discussion_r265854866, I agree with 
@kiszk to skip traversing the arraybuffer after null found.
   @srowen Could you take another look please?
   Thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to