[GitHub] [spark] vicennial commented on a diff in pull request #40256: [SPARK-42653][CONNECT] Artifact transfer from Scala/JVM client to Server

2023-03-03 Thread via GitHub
vicennial commented on code in PR #40256: URL: https://github.com/apache/spark/pull/40256#discussion_r1124398384 ## connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/client/ArtifactSuite.scala: ## @@ -0,0 +1,249 @@ +/* + * Licensed to the Apache Software

[GitHub] [spark] vicennial commented on a diff in pull request #40256: [SPARK-42653][CONNECT] Artifact transfer from Scala/JVM client to Server

2023-03-02 Thread via GitHub
vicennial commented on code in PR #40256: URL: https://github.com/apache/spark/pull/40256#discussion_r1123897616 ## connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/client/ArtifactSuite.scala: ## @@ -0,0 +1,241 @@ +/* + * Licensed to the Apache Software

[GitHub] [spark] vicennial commented on a diff in pull request #40256: [SPARK-42653][CONNECT] Artifact transfer from Scala/JVM client to Server

2023-03-02 Thread via GitHub
vicennial commented on code in PR #40256: URL: https://github.com/apache/spark/pull/40256#discussion_r1123833306 ## connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/connect/client/ArtifactManager.scala: ## @@ -0,0 +1,336 @@ +/* + * Licensed to the Apache

[GitHub] [spark] vicennial commented on a diff in pull request #40256: [SPARK-42653][CONNECT] Artifact transfer from Scala/JVM client to Server

2023-03-02 Thread via GitHub
vicennial commented on code in PR #40256: URL: https://github.com/apache/spark/pull/40256#discussion_r1123829338 ## connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/connect/client/ArtifactManager.scala: ## @@ -0,0 +1,336 @@ +/* + * Licensed to the Apache

[GitHub] [spark] vicennial commented on a diff in pull request #40256: [SPARK-42653][CONNECT] Artifact transfer from Scala/JVM client to Server

2023-03-02 Thread via GitHub
vicennial commented on code in PR #40256: URL: https://github.com/apache/spark/pull/40256#discussion_r1123821569 ## connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/connect/client/ArtifactManager.scala: ## @@ -0,0 +1,336 @@ +/* + * Licensed to the Apache

[GitHub] [spark] vicennial commented on a diff in pull request #40256: [SPARK-42653][CONNECT] Artifact transfer from Scala/JVM client to Server

2023-03-02 Thread via GitHub
vicennial commented on code in PR #40256: URL: https://github.com/apache/spark/pull/40256#discussion_r1123821210 ## connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/connect/client/ArtifactManager.scala: ## @@ -0,0 +1,336 @@ +/* + * Licensed to the Apache