[GitHub] [spark] viirya commented on pull request #28269: [SPARK-31493][SQL] Optimize InSet to In according partition size at InSubqueryExec

2020-06-10 Thread GitBox
viirya commented on pull request #28269: URL: https://github.com/apache/spark/pull/28269#issuecomment-641784863 @cloud-fan Do you still think merging In and InSet is a good idea? This is an automated message from the Apache G

[GitHub] [spark] viirya commented on pull request #28269: [SPARK-31493][SQL] Optimize InSet to In according partition size at InSubqueryExec

2020-04-25 Thread GitBox
viirya commented on pull request #28269: URL: https://github.com/apache/spark/pull/28269#issuecomment-619496712 @cloud-fan Sounds good to me. I think the optimization can be moved into In expression and let it choose to do InSet style optimization when it is suitable. I can make a try late