[GitHub] [spark] wangyum commented on a change in pull request #29088: [SPARK-32289][SQL] Some characters are garbled when opening csv files with Excel

2020-07-14 Thread GitBox
wangyum commented on a change in pull request #29088: URL: https://github.com/apache/spark/pull/29088#discussion_r454764920 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CsvOutputWriter.scala ## @@ -39,6 +39,10 @@ class CsvOutputWriter(

[GitHub] [spark] wangyum commented on a change in pull request #29088: [SPARK-32289][SQL] Some characters are garbled when opening csv files with Excel

2020-07-14 Thread GitBox
wangyum commented on a change in pull request #29088: URL: https://github.com/apache/spark/pull/29088#discussion_r454328505 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/CSVOptions.scala ## @@ -135,6 +135,8 @@ class CSVOptions( val positiveInf

[GitHub] [spark] wangyum commented on a change in pull request #29088: [SPARK-32289][SQL] Some characters are garbled when opening csv files with Excel

2020-07-14 Thread GitBox
wangyum commented on a change in pull request #29088: URL: https://github.com/apache/spark/pull/29088#discussion_r454328241 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala ## @@ -2353,6 +2355,53 @@ abstract class CSVSuite

[GitHub] [spark] wangyum commented on a change in pull request #29088: [SPARK-32289][SQL] Some characters are garbled when opening csv files with Excel

2020-07-14 Thread GitBox
wangyum commented on a change in pull request #29088: URL: https://github.com/apache/spark/pull/29088#discussion_r454249166 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CsvOutputWriter.scala ## @@ -39,6 +39,10 @@ class CsvOutputWriter(

[GitHub] [spark] wangyum commented on a change in pull request #29088: [SPARK-32289][SQL] Some characters are garbled when opening csv files with Excel

2020-07-14 Thread GitBox
wangyum commented on a change in pull request #29088: URL: https://github.com/apache/spark/pull/29088#discussion_r454167871 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala ## @@ -2353,6 +2355,53 @@ abstract class CSVSuite

[GitHub] [spark] wangyum commented on a change in pull request #29088: [SPARK-32289][SQL] Some characters are garbled when opening csv files with Excel

2020-07-13 Thread GitBox
wangyum commented on a change in pull request #29088: URL: https://github.com/apache/spark/pull/29088#discussion_r453726510 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CsvOutputWriter.scala ## @@ -39,6 +39,10 @@ class CsvOutputWriter(