[GitHub] [spark] yaooqinn commented on a change in pull request #28310: [SPARK-31527][SQL] date add/subtract interval only allow those day precision in ansi mode

2020-05-19 Thread GitBox
yaooqinn commented on a change in pull request #28310: URL: https://github.com/apache/spark/pull/28310#discussion_r420874873 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala ## @@ -618,6 +618,22 @@ object DateTimeUtils {

[GitHub] [spark] yaooqinn commented on a change in pull request #28310: [SPARK-31527][SQL] date add/subtract interval only allow those day precision in ansi mode

2020-05-06 Thread GitBox
yaooqinn commented on a change in pull request #28310: URL: https://github.com/apache/spark/pull/28310#discussion_r420874873 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala ## @@ -618,6 +618,22 @@ object DateTimeUtils {

[GitHub] [spark] yaooqinn commented on a change in pull request #28310: [SPARK-31527][SQL] date add/subtract interval only allow those day precision in ansi mode

2020-05-03 Thread GitBox
yaooqinn commented on a change in pull request #28310: URL: https://github.com/apache/spark/pull/28310#discussion_r419149213 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala ## @@ -618,6 +618,22 @@ object DateTimeUtils {

[GitHub] [spark] yaooqinn commented on a change in pull request #28310: [SPARK-31527][SQL] date add/subtract interval only allow those day precision in ansi mode

2020-04-24 Thread GitBox
yaooqinn commented on a change in pull request #28310: URL: https://github.com/apache/spark/pull/28310#discussion_r414332125 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala ## @@ -618,6 +618,22 @@ object DateTimeUtils {

[GitHub] [spark] yaooqinn commented on a change in pull request #28310: [SPARK-31527][SQL] date add/subtract interval only allow those day precision in ansi mode

2020-04-24 Thread GitBox
yaooqinn commented on a change in pull request #28310: URL: https://github.com/apache/spark/pull/28310#discussion_r414332185 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala ## @@ -618,6 +618,22 @@ object DateTimeUtils {

[GitHub] [spark] yaooqinn commented on a change in pull request #28310: [SPARK-31527][SQL] date add/subtract interval only allow those day precision in ansi mode

2020-04-23 Thread GitBox
yaooqinn commented on a change in pull request #28310: URL: https://github.com/apache/spark/pull/28310#discussion_r414266944 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -288,19 +292,22 @@ class Analyzer( * 1. If

[GitHub] [spark] yaooqinn commented on a change in pull request #28310: [SPARK-31527][SQL] date add/subtract interval only allow those day precision in ansi mode

2020-04-23 Thread GitBox
yaooqinn commented on a change in pull request #28310: URL: https://github.com/apache/spark/pull/28310#discussion_r413876113 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -293,14 +297,17 @@ class Analyzer( case p: