[GitHub] [spark] zhengruifeng commented on a diff in pull request #40355: [SPARK-42604][CONNECT] Implement functions.typedlit

2023-03-13 Thread via GitHub
zhengruifeng commented on code in PR #40355: URL: https://github.com/apache/spark/pull/40355#discussion_r1133568797 ## connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/PlanGenerationTestSuite.scala: ## @@ -2065,6 +2065,44 @@ class PlanGenerationTestSuite

[GitHub] [spark] zhengruifeng commented on a diff in pull request #40355: [SPARK-42604][CONNECT] Implement functions.typedlit

2023-03-13 Thread via GitHub
zhengruifeng commented on code in PR #40355: URL: https://github.com/apache/spark/pull/40355#discussion_r1133568797 ## connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/PlanGenerationTestSuite.scala: ## @@ -2065,6 +2065,44 @@ class PlanGenerationTestSuite

[GitHub] [spark] zhengruifeng commented on a diff in pull request #40355: [SPARK-42604][CONNECT] Implement functions.typedlit

2023-03-13 Thread via GitHub
zhengruifeng commented on code in PR #40355: URL: https://github.com/apache/spark/pull/40355#discussion_r1133565363 ## connector/connect/common/src/main/protobuf/spark/connect/expressions.proto: ## @@ -195,6 +197,18 @@ message Expression { DataType element_type = 1;