[GitHub] [spark] zhengruifeng commented on a diff in pull request #40375: [SPARK-42755][CONNECT] Factor literal value conversion out to `connect-common`

2023-03-12 Thread via GitHub
zhengruifeng commented on code in PR #40375: URL: https://github.com/apache/spark/pull/40375#discussion_r1133419950 ## connector/connect/server/src/main/scala/org/apache/spark/sql/connect/planner/LiteralExpressionProtoConverter.scala: ## @@ -192,8 +173,7 @@ object

[GitHub] [spark] zhengruifeng commented on a diff in pull request #40375: [SPARK-42755][CONNECT] Factor literal value conversion out to `connect-common`

2023-03-12 Thread via GitHub
zhengruifeng commented on code in PR #40375: URL: https://github.com/apache/spark/pull/40375#discussion_r1133354786 ## connector/connect/server/src/main/scala/org/apache/spark/sql/connect/planner/LiteralExpressionProtoConverter.scala: ## @@ -107,7 +107,7 @@ object