zhengruifeng commented on code in PR #40500: URL: https://github.com/apache/spark/pull/40500#discussion_r1142863924
########## mllib/src/main/scala/org/apache/spark/mllib/regression/IsotonicRegression.scala: ########## @@ -490,15 +490,13 @@ class IsotonicRegression private (private var isotonic: Boolean) extends Seriali .sortBy(_._2) poolAdjacentViolators(parallelStepResult) } -} -object IsotonicRegression { /** * Utility class, holds a buffer of all points with unique features so far, and performs * weighted sum accumulation of points. Hides these details for better readability of the * main algorithm. */ - class PointsAccumulator { + private class PointsAccumulator { Review Comment: right now it is only used in `IsotonicRegression` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org