[GitHub] [spark] zhengruifeng commented on issue #26679: [SPARK-30044][ML] MNB/CNB/BNB use empty sigma matrix instead of null

2019-12-02 Thread GitBox
zhengruifeng commented on issue #26679: [SPARK-30044][ML] MNB/CNB/BNB use empty sigma matrix instead of null URL: https://github.com/apache/spark/pull/26679#issuecomment-560964613 Merged to master, thanks @srowen for reviewing!

[GitHub] [spark] zhengruifeng commented on issue #26679: [SPARK-30044][ML] MNB/CNB/BNB use empty sigma matrix instead of null

2019-12-01 Thread GitBox
zhengruifeng commented on issue #26679: [SPARK-30044][ML] MNB/CNB/BNB use empty sigma matrix instead of null URL: https://github.com/apache/spark/pull/26679#issuecomment-560203448 @srowen eh, the improvement is small: 1, we do not need to check `sigma==null` in model saving and loading