[GitHub] [spark] zhengruifeng commented on pull request #38411: [SPARK-40933][SQL] Make df.stat.{cov, corr} consistent with sql functions
zhengruifeng commented on PR #38411: URL: https://github.com/apache/spark/pull/38411#issuecomment-1294384281 @HyukjinKwon as far as I know, they are the seem now. the original tests didn't cover null handling and empty dataset, I add a new UT to make sure no behavior change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #38411: [SPARK-40933][SQL] Make df.stat.{cov, corr} consistent with sql functions
zhengruifeng commented on PR #38411: URL: https://github.com/apache/spark/pull/38411#issuecomment-1293442088 seems different null handling, let me update this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
