[GitHub] [spark-docker] Yikun commented on pull request #15: [SPARK-40569] Expose SPARK_MASTER_PORT 7077 for spark standalone cluster
Yikun commented on PR #15: URL: https://github.com/apache/spark-docker/pull/15#issuecomment-1294391023 also cc @holdenk @dongjoon-hyun -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark-docker] Yikun commented on pull request #15: [SPARK-40569] Expose SPARK_MASTER_PORT 7077 for spark standalone cluster
Yikun commented on PR #15: URL: https://github.com/apache/spark-docker/pull/15#issuecomment-1292909604 I guess it's ready? Probably the only potential problem is that the 7077 feels a bit hardcode. If other people think there is a problem, we can temporarily not add 7077. Only add standalone tests wit specified -p `7077`. For standalone tests, I think it is very useful. BTW seems it references some from [link](https://github.com/apache/flink-docker/blob/dev-master/testing/testing_lib.sh) and reimplemetened for Spark, according my test also works well. So, if you think `EXPOSE` port it's a problem, we can specified `-p` first, otherwise all is looks good for me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark-docker] Yikun commented on pull request #15: [SPARK-40569] Expose SPARK_MASTER_PORT 7077 for spark standalone cluster
Yikun commented on PR #15: URL: https://github.com/apache/spark-docker/pull/15#issuecomment-1286598701 cc @HyukjinKwon @zhengruifeng Mind taking a look, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark-docker] Yikun commented on pull request #15: [SPARK-40569] Expose SPARK_MASTER_PORT 7077 for spark standalone cluster
Yikun commented on PR #15: URL: https://github.com/apache/spark-docker/pull/15#issuecomment-1285130451 @dcoliversun Thanks, CI is green. I will take a look soon. A quick question, how many ports should be exposed in future? For common ports, we could write them directly in the dockerfile, and for the less commonly used ones, we can expose them to users through `docker -p port:port` and doc them, WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
