[GitHub] mgaido91 commented on issue #23171: [SPARK-26205][SQL] Optimize In for bytes, shorts, ints

2018-12-15 Thread GitBox
mgaido91 commented on issue #23171: [SPARK-26205][SQL] Optimize In for bytes, shorts, ints URL: https://github.com/apache/spark/pull/23171#issuecomment-447559881 we can keep `spark.sql.optimizer.inSetConversionThreshold` as of now, just read it in `InSet` and behave accordingly. Then, we

[GitHub] mgaido91 commented on issue #23171: [SPARK-26205][SQL] Optimize In for bytes, shorts, ints

2018-12-13 Thread GitBox
mgaido91 commented on issue #23171: [SPARK-26205][SQL] Optimize In for bytes, shorts, ints URL: https://github.com/apache/spark/pull/23171#issuecomment-446916902 thanks @aokolnychyi. I just have a couple of comments on this: 1 - As @rxin mentioned, now we have InSet for handling

[GitHub] mgaido91 commented on issue #23171: [SPARK-26205][SQL] Optimize In for bytes, shorts, ints

2018-12-12 Thread GitBox
mgaido91 commented on issue #23171: [SPARK-26205][SQL] Optimize In for bytes, shorts, ints URL: https://github.com/apache/spark/pull/23171#issuecomment-446526465 thanks @aokolnychyi , may you please post here the result of that benchmark after applying this patch? Just a quick