Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11105
**[Test build #97781 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97781/consoleFull)**
for PR 11105 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11105
**[Test build #97760 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97760/consoleFull)**
for PR 11105 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11105
**[Test build #97760 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97760/consoleFull)**
for PR 11105 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11105
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11105
Build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11105
Build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11105
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97722/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11105
**[Test build #97722 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97722/consoleFull)**
for PR 11105 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11105
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11105
Build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/11105
I think this PR is on hold until Spark 3, but given the discussion on the
mailing list that might not be so far away.
---
-
To
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11105
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11105
Build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user tdyas commented on the issue:
https://github.com/apache/spark/pull/11105
I was curious whether there were any active plans to complete this PR?
---
-
To unsubscribe, e-mail:
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/11105
So if there is interest (cc @squito ) I'm open to update this and go with
the warning signs in the doc approach if there is reviewer interest. Otherwise
I'll kick the tires on this again when were
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/11105
I'm happy to update if someone from core wants to review, but I think there
isn't any reviewer bandwidth. If no reviewers step up, I was planning on
bugging people more when the next majour release
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/11105
Are you still working on this? @holdenk
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/11105
I'm down the idea of having add and merge not be final with huge warning
signs and we could switch it up in 3.X to be final.
---
If your project is set up for it, you can reply to this email and
Github user squito commented on the issue:
https://github.com/apache/spark/pull/11105
I'm thinking about the binary compatability issue specifically with
`DoubleAccumulator` etc. Whether we intended it or not, `DoubleAccumulator` is
not `final`, so a user could have subclassed it.
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/11105
Ok so slipping to 2.2 - I'll keep this up to date and ping everyone again
once 2.1 is out the door.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11105
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11105
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69018/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11105
**[Test build #69018 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69018/consoleFull)**
for PR 11105 at commit
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/11105
Ping for @srowen / @rxin / @squito updated with the latest changes in the
`SparkContext`. The issue is tagged for 2.1.0 and I know were cutting an RC
soon so if there is anything I should to try
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11105
**[Test build #69018 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69018/consoleFull)**
for PR 11105 at commit
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/11105
Just a gentle ping - would be nice to decide on which of the different
options people would like to see so we can get this in for 2.1 :)
---
If your project is set up for it, you can reply to this
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/11105
(cc @rxin / @squito ) :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/11105
oh you want both values as well, sorry I just saw the part about "one
class" @rxin. Is that really an important use case - provided that we keep one
class if someone wants both a data property and
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/11105
Hmm seems github didn't like the / so ping @rxin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/11105
Just a quick reping, I know with all that's been going on in the past few
days this probably dropped of people's radar. CC @rxin/@squito - I's love
y'alls input on which of the three options make
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/11105
Let me know which approach you prefer @rxin - initially this went with the
break binary compat approach then @squito suggested the sub-class approach, but
I'm fine for whichever approach we want to
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/11105
@rxin: we could, although we would need to either break binary
comparability or have some dummy implementations for addImpl so 2.0
accumulators can override add and not provide addImpl.
---
If
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/11105
Is there a way for this to have just one class and have both values
available always?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/11105
So the restricturing to keep binary at compatibility resulted in a few more
changes than I was expecting but what are your thoughts on the restructured
approach @squito?
---
If your project is
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11105
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68227/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11105
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11105
**[Test build #68227 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68227/consoleFull)**
for PR 11105 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11105
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11105
**[Test build #68224 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68224/consoleFull)**
for PR 11105 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11105
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68224/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11105
**[Test build #68227 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68227/consoleFull)**
for PR 11105 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11105
**[Test build #68224 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68224/consoleFull)**
for PR 11105 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11105
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11105
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68218/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11105
**[Test build #68218 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68218/consoleFull)**
for PR 11105 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11105
**[Test build #68218 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68218/consoleFull)**
for PR 11105 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11105
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11105
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68183/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11105
**[Test build #68183 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68183/consoleFull)**
for PR 11105 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11105
**[Test build #68183 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68183/consoleFull)**
for PR 11105 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11105
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11105
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68178/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11105
**[Test build #68178 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68178/consoleFull)**
for PR 11105 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11105
**[Test build #68178 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68178/consoleFull)**
for PR 11105 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11105
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68177/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11105
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11105
**[Test build #68177 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68177/consoleFull)**
for PR 11105 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11105
**[Test build #68177 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68177/consoleFull)**
for PR 11105 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11105
**[Test build #68172 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68172/consoleFull)**
for PR 11105 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11105
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11105
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68172/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11105
**[Test build #68171 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68171/consoleFull)**
for PR 11105 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11105
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11105
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68171/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11105
**[Test build #68172 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68172/consoleFull)**
for PR 11105 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11105
**[Test build #68171 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68171/consoleFull)**
for PR 11105 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11105
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68162/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11105
**[Test build #68162 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68162/consoleFull)**
for PR 11105 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11105
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11105
**[Test build #68162 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68162/consoleFull)**
for PR 11105 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11105
**[Test build #68160 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68160/consoleFull)**
for PR 11105 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11105
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11105
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68160/
Test FAILed.
---
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/11105
Working a bit on the class changes to reduce binary compatibility problems.
For now I've done it so that LongAccumulator and all of the other provided
accumulators inherit from
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11105
**[Test build #68160 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68160/consoleFull)**
for PR 11105 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11105
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68154/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11105
**[Test build #68154 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68154/consoleFull)**
for PR 11105 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11105
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11105
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11105
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68153/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11105
**[Test build #68153 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68153/consoleFull)**
for PR 11105 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11105
**[Test build #68154 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68154/consoleFull)**
for PR 11105 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11105
**[Test build #68153 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68153/consoleFull)**
for PR 11105 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11105
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11105
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68110/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11105
**[Test build #68110 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68110/consoleFull)**
for PR 11105 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11105
**[Test build #68110 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68110/consoleFull)**
for PR 11105 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11105
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11105
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68100/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11105
**[Test build #68100 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68100/consoleFull)**
for PR 11105 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11105
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11105
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68097/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11105
**[Test build #68097 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68097/consoleFull)**
for PR 11105 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11105
**[Test build #68100 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68100/consoleFull)**
for PR 11105 at commit
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/11105
jenkins retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11105
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68093/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11105
**[Test build #68093 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68093/consoleFull)**
for PR 11105 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/11105
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/11105
Thanks for taking the time to do a review pass @squito I really appreciate
it :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/11105
**[Test build #68097 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68097/consoleFull)**
for PR 11105 at commit
1 - 100 of 224 matches
Mail list logo
