Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/12135
I am fine to create a separate one, but, normally, in Spark SQL, we do not
create a separate JIRA for improving the related test case, if the original
ones are missing.
---
If your project is
Github user zhengruifeng commented on the issue:
https://github.com/apache/spark/pull/12135
@MLnick I created
SPARK-19436[https://issues.apache.org/jira/browse/SPARK-19436] for it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user MLnick commented on the issue:
https://github.com/apache/spark/pull/12135
@gatorsmile it's a good point about the tests. However this JIRA & PR was
for exposing the multi-column functionality of `approxQuantiles`. The missing
test cases date back to original impl really.
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/12135
Thanks for the reminder @gatorsmile (it wasn't in the list of things to do
when merging so I'll follow up and update the
http://spark.apache.org/committers.html docs to add that as a follow up step
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/12135
@zhengruifeng Please try to improve the test case coverage in the follow-up
PRs. You might find some bugs when you added these test cases. Thanks for your
work!
---
If your project is set up
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/12135
@zhengruifeng Actually, I still have a few comments about this PR. I will
leave the comments soon. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply
Github user zhengruifeng commented on the issue:
https://github.com/apache/spark/pull/12135
@HyukjinKwon @gatorsmile Thanks for pointing out those issues. I will
create a followup PR to fix them ASAP.
---
If your project is set up for it, you can reply to this email and have your
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/12135
@holdenk When you do the code merge, you need to leave a comment to explain
which branch you merged.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12135
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72237/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12135
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12135
**[Test build #72237 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72237/testReport)**
for PR 12135 at commit
Github user zhengruifeng commented on the issue:
https://github.com/apache/spark/pull/12135
@holdenk Updated! Thanks for your careful checking.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12135
**[Test build #72237 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72237/testReport)**
for PR 12135 at commit
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/12135
Sorry, my weekend ended up super busy. I'll try and take a look tomorrow :)
Also thanks for adding more tests <3 tests :)
---
If your project is set up for it, you can reply to this email and have
Github user zhengruifeng commented on the issue:
https://github.com/apache/spark/pull/12135
ping @holdenk ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12135
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12135
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72070/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12135
**[Test build #72070 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72070/testReport)**
for PR 12135 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12135
**[Test build #72070 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72070/testReport)**
for PR 12135 at commit
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/12135
The Python side looks good & given Nicks LGTM on the other side I'll go
ahead and merge this tonight unless anyone has any objections.
---
If your project is set up for it, you can reply to this
Github user zhengruifeng commented on the issue:
https://github.com/apache/spark/pull/12135
yes spark-18285
https://issues.apache.org/jira/plugins/servlet/mobile#issue/SPARK-18285
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user MLnick commented on the issue:
https://github.com/apache/spark/pull/12135
LGTM. @zhengruifeng did you manage to add a JIRA for exposing multi-col
support in SparkR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user zhengruifeng commented on the issue:
https://github.com/apache/spark/pull/12135
@MLnick @jkbradley Could you mind making a final pass?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user zhengruifeng commented on the issue:
https://github.com/apache/spark/pull/12135
ping @MLnick
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12135
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70902/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12135
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12135
**[Test build #70902 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70902/testReport)**
for PR 12135 at commit
Github user zhengruifeng commented on the issue:
https://github.com/apache/spark/pull/12135
@jkbradley Updated. Thanks for reviewing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12135
**[Test build #70902 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70902/testReport)**
for PR 12135 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12135
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12135
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70813/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12135
**[Test build #70813 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70813/testReport)**
for PR 12135 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12135
**[Test build #70813 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70813/testReport)**
for PR 12135 at commit
Github user zhengruifeng commented on the issue:
https://github.com/apache/spark/pull/12135
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12135
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70805/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12135
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12135
**[Test build #70805 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70805/testReport)**
for PR 12135 at commit
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/12135
ping @MLnick ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12135
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12135
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68930/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12135
**[Test build #68930 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68930/consoleFull)**
for PR 12135 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12135
**[Test build #68930 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68930/consoleFull)**
for PR 12135 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12135
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12135
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68191/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12135
**[Test build #68191 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68191/consoleFull)**
for PR 12135 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12135
**[Test build #68191 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68191/consoleFull)**
for PR 12135 at commit
Github user zhengruifeng commented on the issue:
https://github.com/apache/spark/pull/12135
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12135
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12135
**[Test build #68180 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68180/consoleFull)**
for PR 12135 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12135
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68180/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12135
**[Test build #68180 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68180/consoleFull)**
for PR 12135 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12135
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12135
**[Test build #68130 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68130/consoleFull)**
for PR 12135 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12135
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68130/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12135
**[Test build #68130 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68130/consoleFull)**
for PR 12135 at commit
Github user zhengruifeng commented on the issue:
https://github.com/apache/spark/pull/12135
@MLnick I run sparkR locally, and `approxQuantile` works fine. And I review
the wrapper here
https://github.com/apache/spark/blob/master/R/pkg/R/stats.R#L173
It seem use the single
Github user zhengruifeng commented on the issue:
https://github.com/apache/spark/pull/12135
@MLnick It seems that tests for NaN is added here
https://github.com/apache/spark/blob/master/sql/core/src/test/scala/org/apache/spark/sql/DataFrameStatSuite.scala#L153
SPARK-17219 has
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12135
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12135
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68118/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12135
**[Test build #68118 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68118/consoleFull)**
for PR 12135 at commit
Github user MLnick commented on the issue:
https://github.com/apache/spark/pull/12135
In fact - I'm wondering if the change to the private method for Python will
impact R. From a quick look I suspect R will call the Array-based version, so
should be ok. But please check.
---
If
Github user MLnick commented on the issue:
https://github.com/apache/spark/pull/12135
Also, would you mind adding a JIRA to expose this in SparkR? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12135
**[Test build #68118 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68118/consoleFull)**
for PR 12135 at commit
Github user zhengruifeng commented on the issue:
https://github.com/apache/spark/pull/12135
Jenkins, test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user zhengruifeng commented on the issue:
https://github.com/apache/spark/pull/12135
Just re-ping @MLnick @davies @marmbrus
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/12135
Just re-pinigng @MLnick but we can also see if @davies or @marmbrus have
some cycles to do the final review.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user zhengruifeng commented on the issue:
https://github.com/apache/spark/pull/12135
@MLnick Could you please review this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user zhengruifeng commented on the issue:
https://github.com/apache/spark/pull/12135
@MLnick I have remove the unused api on the Scala side, and only the
multicol version is used.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12135
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66439/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12135
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12135
**[Test build #66439 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66439/consoleFull)**
for PR 12135 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12135
**[Test build #66439 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66439/consoleFull)**
for PR 12135 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12135
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66415/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12135
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12135
**[Test build #66415 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66415/consoleFull)**
for PR 12135 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12135
**[Test build #66415 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66415/consoleFull)**
for PR 12135 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12135
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12135
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66359/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12135
**[Test build #66359 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66359/consoleFull)**
for PR 12135 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12135
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12135
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66363/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12135
**[Test build #66363 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66363/consoleFull)**
for PR 12135 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12135
**[Test build #66363 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66363/consoleFull)**
for PR 12135 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12135
**[Test build #66359 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66359/consoleFull)**
for PR 12135 at commit
Github user zhengruifeng commented on the issue:
https://github.com/apache/spark/pull/12135
Can any admin verify this PR? It's been a long time and I really need this
feature...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12135
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12135
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63208/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12135
**[Test build #63208 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63208/consoleFull)**
for PR 12135 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12135
**[Test build #63208 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63208/consoleFull)**
for PR 12135 at commit
Github user zhengruifeng commented on the issue:
https://github.com/apache/spark/pull/12135
Test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
90 matches
Mail list logo
