[GitHub] spark issue #13447: [SPARK-15706] [SQL] Fix Wrong Answer when using IF NOT E...

2016-06-16 Thread yhuai
Github user yhuai commented on the issue: https://github.com/apache/spark/pull/13447 Thanks. LGTM. Merging to master and branch 2.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

[GitHub] spark issue #13447: [SPARK-15706] [SQL] Fix Wrong Answer when using IF NOT E...

2016-06-16 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/13447 cc @hvanhovell @yhuai Could you please review this PR again? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark issue #13447: [SPARK-15706] [SQL] Fix Wrong Answer when using IF NOT E...

2016-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13447 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60619/ Test PASSed. ---

[GitHub] spark issue #13447: [SPARK-15706] [SQL] Fix Wrong Answer when using IF NOT E...

2016-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13447 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #13447: [SPARK-15706] [SQL] Fix Wrong Answer when using IF NOT E...

2016-06-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13447 **[Test build #60619 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60619/consoleFull)** for PR 13447 at commit [`84ed71a`](https://github.com/apache/spark/commit/

[GitHub] spark issue #13447: [SPARK-15706] [SQL] Fix Wrong Answer when using IF NOT E...

2016-06-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13447 **[Test build #60619 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60619/consoleFull)** for PR 13447 at commit [`84ed71a`](https://github.com/apache/spark/commit/8

[GitHub] spark issue #13447: [SPARK-15706] [SQL] Fix Wrong Answer when using IF NOT E...

2016-06-15 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/13447 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark issue #13447: [SPARK-15706] [SQL] Fix Wrong Answer when using IF NOT E...

2016-06-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13447 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #13447: [SPARK-15706] [SQL] Fix Wrong Answer when using IF NOT E...

2016-06-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13447 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60344/ Test PASSed. ---

[GitHub] spark issue #13447: [SPARK-15706] [SQL] Fix Wrong Answer when using IF NOT E...

2016-06-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13447 **[Test build #60344 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60344/consoleFull)** for PR 13447 at commit [`84ed71a`](https://github.com/apache/spark/commit/

[GitHub] spark issue #13447: [SPARK-15706] [SQL] Fix Wrong Answer when using IF NOT E...

2016-06-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13447 **[Test build #60344 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60344/consoleFull)** for PR 13447 at commit [`84ed71a`](https://github.com/apache/spark/commit/8

[GitHub] spark issue #13447: [SPARK-15706] [SQL] Fix Wrong Answer when using IF NOT E...

2016-06-11 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/13447 @yhuai You are right. This is not a good test case for verifying this. I will add a case like ```scala sql( """ |INSERT OVERWRITE TABLE table_with_partitio

[GitHub] spark issue #13447: [SPARK-15706] [SQL] Fix Wrong Answer when using IF NOT E...

2016-06-10 Thread yhuai
Github user yhuai commented on the issue: https://github.com/apache/spark/pull/13447 Seems the behavior of the following query is weird (if it works). (the case without IF NOT EXISTS) ``` INSERT OVERWRITE TABLE table_with_partition partition (p1='a',p2) SELECT 'blarr3'

[GitHub] spark issue #13447: [SPARK-15706] [SQL] Fix Wrong Answer when using IF NOT E...

2016-06-08 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/13447 @hvanhovell Does the latest code changes resolve your comment? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] spark issue #13447: [SPARK-15706] [SQL] Fix Wrong Answer when using IF NOT E...

2016-06-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13447 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #13447: [SPARK-15706] [SQL] Fix Wrong Answer when using IF NOT E...

2016-06-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13447 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60098/ Test PASSed. ---

[GitHub] spark issue #13447: [SPARK-15706] [SQL] Fix Wrong Answer when using IF NOT E...

2016-06-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13447 **[Test build #60098 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60098/consoleFull)** for PR 13447 at commit [`bbaad66`](https://github.com/apache/spark/commit/

[GitHub] spark issue #13447: [SPARK-15706] [SQL] Fix Wrong Answer when using IF NOT E...

2016-06-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13447 **[Test build #60098 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60098/consoleFull)** for PR 13447 at commit [`bbaad66`](https://github.com/apache/spark/commit/b

[GitHub] spark issue #13447: [SPARK-15706] [SQL] Fix Wrong Answer when using IF NOT E...

2016-06-06 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/13447 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark issue #13447: [SPARK-15706] [SQL] Fix Wrong Answer when using IF NOT E...

2016-06-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13447 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59873/ Test PASSed. ---

[GitHub] spark issue #13447: [SPARK-15706] [SQL] Fix Wrong Answer when using IF NOT E...

2016-06-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13447 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #13447: [SPARK-15706] [SQL] Fix Wrong Answer when using IF NOT E...

2016-06-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13447 **[Test build #59873 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59873/consoleFull)** for PR 13447 at commit [`bbaad66`](https://github.com/apache/spark/commit/

[GitHub] spark issue #13447: [SPARK-15706] [SQL] Fix Wrong Answer when using IF NOT E...

2016-06-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13447 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #13447: [SPARK-15706] [SQL] Fix Wrong Answer when using IF NOT E...

2016-06-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13447 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59865/ Test PASSed. ---

[GitHub] spark issue #13447: [SPARK-15706] [SQL] Fix Wrong Answer when using IF NOT E...

2016-06-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13447 **[Test build #59865 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59865/consoleFull)** for PR 13447 at commit [`be187d8`](https://github.com/apache/spark/commit/

[GitHub] spark issue #13447: [SPARK-15706] [SQL] Fix Wrong Answer when using IF NOT E...

2016-06-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13447 **[Test build #59873 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59873/consoleFull)** for PR 13447 at commit [`bbaad66`](https://github.com/apache/spark/commit/b

[GitHub] spark issue #13447: [SPARK-15706] [SQL] Fix Wrong Answer when using IF NOT E...

2016-06-02 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/13447 I think your concern is valid. Will add an `assert` in `InsertIntoTable`. So far, dynamic partitioning is used by the `insertInto` API. However, there is no way to specify `IF NOT EXISTS`

[GitHub] spark issue #13447: [SPARK-15706] [SQL] Fix Wrong Answer when using IF NOT E...

2016-06-02 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/13447 @gatorsmile the overall approach seems good to me. We are currently fixing this for the SQL codepath. I was wondering if are other codepaths that can cause this unwanted behavior? If there are th

[GitHub] spark issue #13447: [SPARK-15706] [SQL] Fix Wrong Answer when using IF NOT E...

2016-06-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13447 **[Test build #59865 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59865/consoleFull)** for PR 13447 at commit [`be187d8`](https://github.com/apache/spark/commit/b

[GitHub] spark issue #13447: [SPARK-15706] [SQL] Fix Wrong Answer when using IF NOT E...

2016-06-01 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/13447 cc @liancheng @hvanhovell @yhuai --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[GitHub] spark issue #13447: [SPARK-15706] [SQL] Fix Wrong Answer when using IF NOT E...

2016-06-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13447 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59755/ Test PASSed. ---

[GitHub] spark issue #13447: [SPARK-15706] [SQL] Fix Wrong Answer when using IF NOT E...

2016-06-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13447 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #13447: [SPARK-15706] [SQL] Fix Wrong Answer when using IF NOT E...

2016-06-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13447 **[Test build #59755 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59755/consoleFull)** for PR 13447 at commit [`70d9cad`](https://github.com/apache/spark/commit/

[GitHub] spark issue #13447: [SPARK-15706] [SQL] Fix Wrong Answer when using IF NOT E...

2016-06-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13447 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #13447: [SPARK-15706] [SQL] Fix Wrong Answer when using IF NOT E...

2016-06-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13447 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59753/ Test PASSed. ---

[GitHub] spark issue #13447: [SPARK-15706] [SQL] Fix Wrong Answer when using IF NOT E...

2016-06-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13447 **[Test build #59753 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59753/consoleFull)** for PR 13447 at commit [`61f0632`](https://github.com/apache/spark/commit/

[GitHub] spark issue #13447: [SPARK-15706] [SQL] Fix Wrong Answer when using IF NOT E...

2016-06-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13447 **[Test build #59755 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59755/consoleFull)** for PR 13447 at commit [`70d9cad`](https://github.com/apache/spark/commit/7

[GitHub] spark issue #13447: [SPARK-15706] [SQL] Fix Wrong Answer when using IF NOT E...

2016-06-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13447 **[Test build #59753 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59753/consoleFull)** for PR 13447 at commit [`61f0632`](https://github.com/apache/spark/commit/6