[GitHub] spark issue #13522: [SPARK-14321][SQL] Reduce date format cost and string-to...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/13522 Some more ideas: I think we should create a subclass of `UnixTime` to handle the `left.dataType == StringType && right.foldable` case. In optimizer, we can replace it with null literal if the `formatter` is null, then we don't need to do null check for every record, like this PR did. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13522: [SPARK-14321][SQL] Reduce date format cost and string-to...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13522 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60118/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13522: [SPARK-14321][SQL] Reduce date format cost and string-to...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13522 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13522: [SPARK-14321][SQL] Reduce date format cost and string-to...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13522 **[Test build #60118 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60118/consoleFull)** for PR 13522 at commit [`425aa7e`](https://github.com/apache/spark/commit/425aa7ea30f1f92143fc9f539c7b928255dee1c9). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13522: [SPARK-14321][SQL] Reduce date format cost and string-to...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13522 **[Test build #60118 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60118/consoleFull)** for PR 13522 at commit [`425aa7e`](https://github.com/apache/spark/commit/425aa7ea30f1f92143fc9f539c7b928255dee1c9). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13522: [SPARK-14321][SQL] Reduce date format cost and string-to...
Github user rajeshbalamohan commented on the issue: https://github.com/apache/spark/pull/13522 Thank you. I have pushed the fixes in the recent commit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13522: [SPARK-14321][SQL] Reduce date format cost and string-to...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/13522 LGTM except one naming comments, thanks for working on it! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13522: [SPARK-14321][SQL] Reduce date format cost and string-to...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13522 **[Test build #60042 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60042/consoleFull)** for PR 13522 at commit [`602d4a7`](https://github.com/apache/spark/commit/602d4a70ba845df3160a07c2c9afe2d5c3c574c4). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13522: [SPARK-14321][SQL] Reduce date format cost and string-to...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13522 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60042/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13522: [SPARK-14321][SQL] Reduce date format cost and string-to...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13522 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13522: [SPARK-14321][SQL] Reduce date format cost and string-to...
Github user rajeshbalamohan commented on the issue: https://github.com/apache/spark/pull/13522 @cloud-fan - Sorry about the delay. Rebased SPARK-14321 for master. https://github.com/apache/spark/pull/12105 had become stale and got little messy in my system. Ended up creating this PR. I will close the earlier one after review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13522: [SPARK-14321][SQL] Reduce date format cost and string-to...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13522 **[Test build #60042 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60042/consoleFull)** for PR 13522 at commit [`602d4a7`](https://github.com/apache/spark/commit/602d4a70ba845df3160a07c2c9afe2d5c3c574c4). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
