[GitHub] spark issue #14493: [#SPARK-16897] Refactored the code and changed the var t...

2016-08-04 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14493 This should be closed, please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #14493: [#SPARK-16897] Refactored the code and changed the var t...

2016-08-04 Thread shiv4nsh
Github user shiv4nsh commented on the issue: https://github.com/apache/spark/pull/14493 @srowen : But do change it by yourself if you have time , because that was a bit confusing for a new user because of the point at which it is present --- If your project is set up for it, you

[GitHub] spark issue #14493: [#SPARK-16897] Refactored the code and changed the var t...

2016-08-04 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14493 Yes, this is below the threshold. We want to encourage focus on slightly more meaningful changes because it takes probably a person-hour to look at any change and there is so much demand. Your

[GitHub] spark issue #14493: [#SPARK-16897] Refactored the code and changed the var t...

2016-08-04 Thread shiv4nsh
Github user shiv4nsh commented on the issue: https://github.com/apache/spark/pull/14493 @srowen : One more thing I have found in the docs that some of the links are broken and they are not pointing to the place that they should point. So should I make the change for that too or can

[GitHub] spark issue #14493: [#SPARK-16897] Refactored the code and changed the var t...

2016-08-04 Thread shiv4nsh
Github user shiv4nsh commented on the issue: https://github.com/apache/spark/pull/14493 @srowen : I found out that var is used here and then I got confused that why as there is no need , hence I made this pull request. If you feel that this can't be merged. Let me know I will close

[GitHub] spark issue #14493: [#SPARK-16897] Refactored the code and changed the var t...

2016-08-04 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14493 This is too trivial to make a change for. Yes it is better to write val but not worth everyone's time to process single line changes like this that are almost a no op --- If your project is set up

[GitHub] spark issue #14493: [#SPARK-16897] Refactored the code and changed the var t...

2016-08-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14493 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this