[GitHub] spark issue #15034: [SPARK-16240][ML] ML persistence backward compatibility ...
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/15034 I'll go ahead and merge this. Thanks @hhbyyh for reviewing it! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15034: [SPARK-16240][ML] ML persistence backward compatibility ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15034 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15034: [SPARK-16240][ML] ML persistence backward compatibility ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15034 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65789/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15034: [SPARK-16240][ML] ML persistence backward compatibility ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15034 **[Test build #65789 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65789/consoleFull)** for PR 15034 at commit [`3b499df`](https://github.com/apache/spark/commit/3b499df2a7681621a6bbd7bb1037f43af0d7e197). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15034: [SPARK-16240][ML] ML persistence backward compatibility ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15034 **[Test build #65789 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65789/consoleFull)** for PR 15034 at commit [`3b499df`](https://github.com/apache/spark/commit/3b499df2a7681621a6bbd7bb1037f43af0d7e197). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15034: [SPARK-16240][ML] ML persistence backward compatibility ...
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/15034 @JoshRosen That is weird; MiMa passes for me locally, but I see that it shouldn't. I added a MiMaException; this should not be a problem for users. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15034: [SPARK-16240][ML] ML persistence backward compatibility ...
Github user JoshRosen commented on the issue:
https://github.com/apache/spark/pull/15034
@jkbradley, it looks like this is legitimately failing MiMa (not sure why
it passed on the first run...):
```
[error] * the type hierarchy of object org.apache.spark.ml.clustering.LDA
is different in current version. Missing types
{org.apache.spark.ml.util.DefaultParamsReadable}
[error]filter with:
ProblemFilters.exclude[MissingTypesProblem]("org.apache.spark.ml.clustering.LDA$")
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15034: [SPARK-16240][ML] ML persistence backward compatibility ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15034 **[Test build #65621 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65621/consoleFull)** for PR 15034 at commit [`a931b25`](https://github.com/apache/spark/commit/a931b25ae91bbfa67adf4b5209d0603d0a73b4cc). * This patch **fails MiMa tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15034: [SPARK-16240][ML] ML persistence backward compatibility ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15034 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65621/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15034: [SPARK-16240][ML] ML persistence backward compatibility ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15034 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15034: [SPARK-16240][ML] ML persistence backward compatibility ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15034 **[Test build #65621 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65621/consoleFull)** for PR 15034 at commit [`a931b25`](https://github.com/apache/spark/commit/a931b25ae91bbfa67adf4b5209d0603d0a73b4cc). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15034: [SPARK-16240][ML] ML persistence backward compatibility ...
Github user JoshRosen commented on the issue: https://github.com/apache/spark/pull/15034 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15034: [SPARK-16240][ML] ML persistence backward compatibility ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15034 **[Test build #3279 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3279/consoleFull)** for PR 15034 at commit [`a931b25`](https://github.com/apache/spark/commit/a931b25ae91bbfa67adf4b5209d0603d0a73b4cc). * This patch **fails Spark unit tests**. * This patch **does not merge cleanly**. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15034: [SPARK-16240][ML] ML persistence backward compatibility ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15034 **[Test build #3279 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3279/consoleFull)** for PR 15034 at commit [`a931b25`](https://github.com/apache/spark/commit/a931b25ae91bbfa67adf4b5209d0603d0a73b4cc). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15034: [SPARK-16240][ML] ML persistence backward compatibility ...
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/15034 Thanks @hhbyyh ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15034: [SPARK-16240][ML] ML persistence backward compatibility ...
Github user hhbyyh commented on the issue: https://github.com/apache/spark/pull/15034 Thanks @jkbradley. This matches what I had in mind. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15034: [SPARK-16240][ML] ML persistence backward compatibility ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15034 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65168/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15034: [SPARK-16240][ML] ML persistence backward compatibility ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15034 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15034: [SPARK-16240][ML] ML persistence backward compatibility ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15034 **[Test build #65168 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65168/consoleFull)** for PR 15034 at commit [`a931b25`](https://github.com/apache/spark/commit/a931b25ae91bbfa67adf4b5209d0603d0a73b4cc). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15034: [SPARK-16240][ML] ML persistence backward compatibility ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15034 **[Test build #65168 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65168/consoleFull)** for PR 15034 at commit [`a931b25`](https://github.com/apache/spark/commit/a931b25ae91bbfa67adf4b5209d0603d0a73b4cc). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15034: [SPARK-16240][ML] ML persistence backward compatibility ...
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/15034 **To reviewers**: This code was taken and modified from [https://github.com/apache/spark/pull/14112]. @GayathriMurali should be the primary author when we merge this into master and branch-2.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15034: [SPARK-16240][ML] ML persistence backward compatibility ...
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/15034 CC @hhbyyh Would you mind taking a look? thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
