Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/15139
I will merge this into master. If anyone has more comments, I can address
them at follow-up work. Thanks for your review. @felixcheung
---
If your project is set up for it, you can reply to
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/15139
LGTM, @junyangq do you have any comment?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15139
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65656/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15139
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15139
**[Test build #65656 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65656/consoleFull)**
for PR 15139 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15139
**[Test build #65656 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65656/consoleFull)**
for PR 15139 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15139
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65572/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15139
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15139
**[Test build #65572 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65572/consoleFull)**
for PR 15139 at commit
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/15139
@felixcheung I agree with you and added test to check the R print method is
doing sth. Any more comments, feel free to let me know. Thanks!
---
If your project is set up for it, you can reply
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15139
**[Test build #65572 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65572/consoleFull)**
for PR 15139 at commit
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/15139
I agree we don't need to check the full output but we should check the R
print method is doing something - without a test, we have it broken before.
Generally we should have a test at
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/15139
@junyangq
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15139
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15139
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65568/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15139
**[Test build #65568 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65568/consoleFull)**
for PR 15139 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15139
**[Test build #65568 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65568/consoleFull)**
for PR 15139 at commit
17 matches
Mail list logo