Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/15232
Hm.. I took some issues in `testthat` and I think that is an expected
behaviour(?). (Please take a look for the issue 224 in `testthat`). I asked a
question to the author of that library.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/15232
Sure, I will take a look for this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/15232
Hmm, thanks.
I thought we had "turn warning to error" in test - any idea why these
didn't error out in the PR before it was merged?
---
If your project is set up for it, you can
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/15232
Sorry, I left and removed a wring comment. Please ignore that. Sure, I will
rather try to add an explicit check before that.
---
If your project is set up for it, you can reply to this email
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/15232
Sure, I trust your judgement. Coould you please guide me please? (Is there
a common logic to check this?)
---
If your project is set up for it, you can reply to this email and have your
reply
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/15232
Thanks @HyukjinKwon - Fix looks good. But isn't it better to do the check
before we do the na.omit / as.integer ? Or will that miss some cases ?
---
If your project is set up for it, you can
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15232
**[Test build #65867 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65867/consoleFull)**
for PR 15232 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15232
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65867/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15232
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15232
**[Test build #65867 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65867/consoleFull)**
for PR 15232 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/15232
cc @felixcheung and @shivaram
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
11 matches
Mail list logo
