[GitHub] spark issue #15568: [SPARK-18028][SQL] simplify TableFileCatalog

2016-10-24 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/15568 thanks for the review, merging to master! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #15568: [SPARK-18028][SQL] simplify TableFileCatalog

2016-10-24 Thread ericl
Github user ericl commented on the issue: https://github.com/apache/spark/pull/15568 lgtm, thanks for adding the test! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #15568: [SPARK-18028][SQL] simplify TableFileCatalog

2016-10-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15568 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15568: [SPARK-18028][SQL] simplify TableFileCatalog

2016-10-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15568 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67444/ Test PASSed. ---

[GitHub] spark issue #15568: [SPARK-18028][SQL] simplify TableFileCatalog

2016-10-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15568 **[Test build #67444 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67444/consoleFull)** for PR 15568 at commit

[GitHub] spark issue #15568: [SPARK-18028][SQL] simplify TableFileCatalog

2016-10-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15568 **[Test build #67444 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67444/consoleFull)** for PR 15568 at commit

[GitHub] spark issue #15568: [SPARK-18028][SQL] simplify TableFileCatalog

2016-10-20 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/15568 @mallman , item 4 is a potential problem in the future. The current workflow is, we get the `MetastoreRelation` via `HiveMetastoreCatalog.lookupRelation`, which always lower case the database and

[GitHub] spark issue #15568: [SPARK-18028][SQL] simplify TableFileCatalog

2016-10-20 Thread ericl
Github user ericl commented on the issue: https://github.com/apache/spark/pull/15568 LGTM, but had a question on why we need to override equals(). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark issue #15568: [SPARK-18028][SQL] simplify TableFileCatalog

2016-10-20 Thread mallman
Github user mallman commented on the issue: https://github.com/apache/spark/pull/15568 @cloud-fan, I don't know what you mean in item 4 about `SessionCatalog.listPartitionsByFilter` handling case-sensitivity. What case-sensitivity issue are you referring to, and does this PR handle

[GitHub] spark issue #15568: [SPARK-18028][SQL] simplify TableFileCatalog

2016-10-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15568 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15568: [SPARK-18028][SQL] simplify TableFileCatalog

2016-10-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15568 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67266/ Test PASSed. ---

[GitHub] spark issue #15568: [SPARK-18028][SQL] simplify TableFileCatalog

2016-10-20 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15568 **[Test build #67266 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67266/consoleFull)** for PR 15568 at commit

[GitHub] spark issue #15568: [SPARK-18028][SQL] simplify TableFileCatalog

2016-10-20 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15568 **[Test build #67266 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67266/consoleFull)** for PR 15568 at commit

[GitHub] spark issue #15568: [SPARK-18028][SQL] simplify TableFileCatalog

2016-10-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15568 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67265/ Test FAILed. ---

[GitHub] spark issue #15568: [SPARK-18028][SQL] simplify TableFileCatalog

2016-10-20 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15568 **[Test build #67265 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67265/consoleFull)** for PR 15568 at commit

[GitHub] spark issue #15568: [SPARK-18028][SQL] simplify TableFileCatalog

2016-10-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15568 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15568: [SPARK-18028][SQL] simplify TableFileCatalog

2016-10-20 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/15568 cc @ericl @mallman @yhuai --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #15568: [SPARK-18028][SQL] simplify TableFileCatalog

2016-10-20 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15568 **[Test build #67265 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67265/consoleFull)** for PR 15568 at commit