[GitHub] spark issue #15934: [SPARK-18497][SS]Make ForeachSink support watermark

2016-11-18 Thread tdas
Github user tdas commented on the issue: https://github.com/apache/spark/pull/15934 Seems like this is a correctness bug as aggregation will give wrong results when using aggregations. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark issue #15934: [SPARK-18497][SS]Make ForeachSink support watermark

2016-11-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15934 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15934: [SPARK-18497][SS]Make ForeachSink support watermark

2016-11-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15934 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68873/ Test PASSed. ---

[GitHub] spark issue #15934: [SPARK-18497][SS]Make ForeachSink support watermark

2016-11-18 Thread tdas
Github user tdas commented on the issue: https://github.com/apache/spark/pull/15934 Merging to master, 2.1 and 2.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #15934: [SPARK-18497][SS]Make ForeachSink support watermark

2016-11-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15934 **[Test build #68873 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68873/consoleFull)** for PR 15934 at commit

[GitHub] spark issue #15934: [SPARK-18497][SS]Make ForeachSink support watermark

2016-11-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15934 **[Test build #68873 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68873/consoleFull)** for PR 15934 at commit

[GitHub] spark issue #15934: [SPARK-18497][SS]Make ForeachSink support watermark

2016-11-18 Thread marmbrus
Github user marmbrus commented on the issue: https://github.com/apache/spark/pull/15934 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #15934: [SPARK-18497][SS]Make ForeachSink support watermark

2016-11-18 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/15934 cc @marmbrus --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if