Github user JoshRosen commented on the issue:
https://github.com/apache/spark/pull/15986
Alright, I'm going to merge this now and will open backport PRs against the
other branches. Thanks for reviewing!
---
If your project is set up for it, you can reply to this email and have your
Github user markhamstra commented on the issue:
https://github.com/apache/spark/pull/15986
Thanks, @JoshRosen
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user JoshRosen commented on the issue:
https://github.com/apache/spark/pull/15986
@markhamstra, I'll fix that in a followup patch to address the pre-existing
synchronization / thread-safety issue impacting that method.
---
If your project is set up for it, you can reply to
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/15986
Thanks for all of the work on this Josh! Happy to review the version for
master if the merge isn't clean.
---
If your project is set up for it, you can reply to this email and have your
Github user markhamstra commented on the issue:
https://github.com/apache/spark/pull/15986
If Kay is happy with the last couple of changes, then I'm fine with this,
too. The only tiny nit I've still got is a change from
`runningTasksByExecutors()` to `runningTasksByExecutors`.
Github user JoshRosen commented on the issue:
https://github.com/apache/spark/pull/15986
@kayousterhout, @markhamstra, I believe that I've addressed all of the
outstanding review comments, so do you want to take a final look at this to see
whether it's ready to go?
---
If your
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15986
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15986
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69218/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15986
**[Test build #69218 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69218/consoleFull)**
for PR 15986 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15986
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15986
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69216/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15986
**[Test build #69216 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69216/consoleFull)**
for PR 15986 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15986
**[Test build #69218 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69218/consoleFull)**
for PR 15986 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15986
**[Test build #69216 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69216/consoleFull)**
for PR 15986 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15986
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69095/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15986
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15986
**[Test build #69095 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69095/consoleFull)**
for PR 15986 at commit
Github user JoshRosen commented on the issue:
https://github.com/apache/spark/pull/15986
I think that we can extend some of our existing tests in
`TaskSchedulerImpl` suite to add the `statusUpdate()` calls that we might
expect to see in the wild, but this will require a bit more
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15986
**[Test build #69095 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69095/consoleFull)**
for PR 15986 at commit
Github user JoshRosen commented on the issue:
https://github.com/apache/spark/pull/15986
Thanks for the review pass. I'll split the thread-safety fix into a
separate PR and will work on addressing your comments now.
I'll see about adding new unit tests to cover the
Github user markhamstra commented on the issue:
https://github.com/apache/spark/pull/15986
The code looks pretty good @JoshRosen , but I still want to spend some time
looking at your standalone end-to-end reproduction to get more familiar with
the details.
---
If your project is
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15986
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15986
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69062/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15986
**[Test build #69062 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69062/consoleFull)**
for PR 15986 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15986
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15986
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69060/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15986
**[Test build #69060 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69060/consoleFull)**
for PR 15986 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15986
**[Test build #69062 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69062/consoleFull)**
for PR 15986 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15986
**[Test build #69060 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69060/consoleFull)**
for PR 15986 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15986
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15986
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69053/
Test PASSed.
---
Github user JoshRosen commented on the issue:
https://github.com/apache/spark/pull/15986
I managed to come up with a standalone end-to-end reproduction of the
shuffle file leak, allowing me to validate this patch's fix.
Run
```
./bin/spark-shell
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15986
**[Test build #69053 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69053/consoleFull)**
for PR 15986 at commit
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/15986
cc @tejasapatil
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15986
**[Test build #69053 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69053/consoleFull)**
for PR 15986 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15986
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15986
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69046/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15986
**[Test build #69046 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69046/consoleFull)**
for PR 15986 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15986
**[Test build #69046 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69046/consoleFull)**
for PR 15986 at commit
39 matches
Mail list logo
