[GitHub] spark issue #16637: [SPARK-19225][SQL]round decimal return normal value but ...

2017-01-22 Thread discipleforteen
Github user discipleforteen commented on the issue: https://github.com/apache/spark/pull/16637 how about cast constant 4.4 to double instead of decimal like spark 1.x. @rxin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark issue #16637: [SPARK-19225][SQL]round decimal return normal value but ...

2017-01-20 Thread discipleforteen
Github user discipleforteen commented on the issue: https://github.com/apache/spark/pull/16637 @AmplabJenkins @rxin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #16637: [SPARK-19225][SQL]round decimal return normal value but ...

2017-01-19 Thread discipleforteen
Github user discipleforteen commented on the issue: https://github.com/apache/spark/pull/16637 ok. i will try to update code gen and MathFunctionsSuite.scala --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #16637: [SPARK-19225][SQL]round decimal return normal value but ...

2017-01-19 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/16637 Also I think we need to update the code gen path as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark issue #16637: [SPARK-19225][SQL]round decimal return normal value but ...

2017-01-19 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/16637 Can you add a test? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #16637: [SPARK-19225][SQL]round decimal return normal value but ...

2017-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16637 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this