Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17062
Thanks! Merging to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17062
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74416/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17062
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17062
**[Test build #74416 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74416/testReport)**
for PR 17062 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17062
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17062
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74414/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17062
**[Test build #74414 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74414/testReport)**
for PR 17062 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17062
**[Test build #74416 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74416/testReport)**
for PR 17062 at commit
Github user tejasapatil commented on the issue:
https://github.com/apache/spark/pull/17062
@gatorsmile : Thanks for the review :) Added method doc for `hash()` with
the comment as suggested.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17062
@tejasapatil Thanks for your work! Could you add a comment in the `hash`
function? The caller of `hash` needs to check the validity of input values.
LGTM pending test.
---
If
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17062
I did the same check. The results of Hive 2.0 exactly match the hard-coded
values.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17062
**[Test build #74414 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74414/testReport)**
for PR 17062 at commit
Github user tejasapatil commented on the issue:
https://github.com/apache/spark/pull/17062
cc @gatorsmile
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17062
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74278/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17062
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17062
**[Test build #74278 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74278/testReport)**
for PR 17062 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17062
**[Test build #74278 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74278/testReport)**
for PR 17062 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17062
It sounds like no test case covers nanosecond for INTERVAL
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17062
Will review it tonight. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user tejasapatil commented on the issue:
https://github.com/apache/spark/pull/17062
Updated comments with the corresponding hive queries used to generate the
expected outputs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user tejasapatil commented on the issue:
https://github.com/apache/spark/pull/17062
@gatorsmile : can you please review this PR ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17062
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73472/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17062
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17062
**[Test build #73472 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73472/testReport)**
for PR 17062 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17062
**[Test build #73472 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73472/testReport)**
for PR 17062 at commit
Github user tejasapatil commented on the issue:
https://github.com/apache/spark/pull/17062
Jenkins retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17062
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17062
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73459/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17062
**[Test build #73459 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73459/testReport)**
for PR 17062 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17062
**[Test build #73459 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73459/testReport)**
for PR 17062 at commit
Github user tejasapatil commented on the issue:
https://github.com/apache/spark/pull/17062
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
31 matches
Mail list logo
