[GitHub] spark issue #17120: [SPARK-19715][Structured Streaming] Option to Strip Path...
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/17120 LGTM. Merging to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17120: [SPARK-19715][Structured Streaming] Option to Strip Path...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17120 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74260/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17120: [SPARK-19715][Structured Streaming] Option to Strip Path...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17120 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17120: [SPARK-19715][Structured Streaming] Option to Strip Path...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17120 **[Test build #74260 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74260/testReport)** for PR 17120 at commit [`aab7554`](https://github.com/apache/spark/commit/aab75540b314abcd1b4fe557bb7a4aa2b7bdc072). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17120: [SPARK-19715][Structured Streaming] Option to Strip Path...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17120 **[Test build #74260 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74260/testReport)** for PR 17120 at commit [`aab7554`](https://github.com/apache/spark/commit/aab75540b314abcd1b4fe557bb7a4aa2b7bdc072). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17120: [SPARK-19715][Structured Streaming] Option to Strip Path...
Github user lw-lin commented on the issue: https://github.com/apache/spark/pull/17120 Jenkins retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17120: [SPARK-19715][Structured Streaming] Option to Strip Path...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17120 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17120: [SPARK-19715][Structured Streaming] Option to Strip Path...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17120 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74245/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17120: [SPARK-19715][Structured Streaming] Option to Strip Path...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17120 **[Test build #74245 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74245/testReport)** for PR 17120 at commit [`aab7554`](https://github.com/apache/spark/commit/aab75540b314abcd1b4fe557bb7a4aa2b7bdc072). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17120: [SPARK-19715][Structured Streaming] Option to Strip Path...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17120 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74236/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17120: [SPARK-19715][Structured Streaming] Option to Strip Path...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17120 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17120: [SPARK-19715][Structured Streaming] Option to Strip Path...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17120 **[Test build #74236 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74236/testReport)** for PR 17120 at commit [`7da2a9c`](https://github.com/apache/spark/commit/7da2a9cccd6c18e1c0eda542977aec00eca33459). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17120: [SPARK-19715][Structured Streaming] Option to Strip Path...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17120 **[Test build #74236 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74236/testReport)** for PR 17120 at commit [`7da2a9c`](https://github.com/apache/spark/commit/7da2a9cccd6c18e1c0eda542977aec00eca33459). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17120: [SPARK-19715][Structured Streaming] Option to Strip Path...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17120 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17120: [SPARK-19715][Structured Streaming] Option to Strip Path...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17120 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74062/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17120: [SPARK-19715][Structured Streaming] Option to Strip Path...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17120 **[Test build #74062 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74062/testReport)** for PR 17120 at commit [`f9e525e`](https://github.com/apache/spark/commit/f9e525e54de1ceb98fa3e21c92969559c65a24fd). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17120: [SPARK-19715][Structured Streaming] Option to Strip Path...
Github user lw-lin commented on the issue: https://github.com/apache/spark/pull/17120 Jenkins retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17120: [SPARK-19715][Structured Streaming] Option to Strip Path...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17120 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73900/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17120: [SPARK-19715][Structured Streaming] Option to Strip Path...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17120 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17120: [SPARK-19715][Structured Streaming] Option to Strip Path...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17120 **[Test build #73900 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73900/testReport)** for PR 17120 at commit [`f9e525e`](https://github.com/apache/spark/commit/f9e525e54de1ceb98fa3e21c92969559c65a24fd). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17120: [SPARK-19715][Structured Streaming] Option to Strip Path...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17120 **[Test build #73900 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73900/testReport)** for PR 17120 at commit [`f9e525e`](https://github.com/apache/spark/commit/f9e525e54de1ceb98fa3e21c92969559c65a24fd). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17120: [SPARK-19715][Structured Streaming] Option to Strip Path...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17120 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73885/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17120: [SPARK-19715][Structured Streaming] Option to Strip Path...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17120 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17120: [SPARK-19715][Structured Streaming] Option to Strip Path...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17120 **[Test build #73885 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73885/testReport)** for PR 17120 at commit [`2354ae6`](https://github.com/apache/spark/commit/2354ae69f8906e654a6881fb87b7aabfe008885e). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17120: [SPARK-19715][Structured Streaming] Option to Strip Path...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17120 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73884/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17120: [SPARK-19715][Structured Streaming] Option to Strip Path...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17120 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17120: [SPARK-19715][Structured Streaming] Option to Strip Path...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17120 **[Test build #73884 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73884/testReport)** for PR 17120 at commit [`c59f35f`](https://github.com/apache/spark/commit/c59f35f34c753afaa679dbccb5107f1a9128482c). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17120: [SPARK-19715][Structured Streaming] Option to Strip Path...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17120 **[Test build #73885 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73885/testReport)** for PR 17120 at commit [`2354ae6`](https://github.com/apache/spark/commit/2354ae69f8906e654a6881fb87b7aabfe008885e). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17120: [SPARK-19715][Structured Streaming] Option to Strip Path...
Github user lw-lin commented on the issue: https://github.com/apache/spark/pull/17120 Thank you @marmbrus @steveloughran for the feedback. Added some explicit docs. Here's a screenshot of the affected section from the programming guide:  Please take a look again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17120: [SPARK-19715][Structured Streaming] Option to Strip Path...
Github user lw-lin commented on the issue: https://github.com/apache/spark/pull/17120 Thank you @marmbrus @steveloughran for the feedback. I've added some explicit docs. Here's a screenshot of the affected section from the programming guide:  Please take a look again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17120: [SPARK-19715][Structured Streaming] Option to Strip Path...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17120 **[Test build #73884 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73884/testReport)** for PR 17120 at commit [`c59f35f`](https://github.com/apache/spark/commit/c59f35f34c753afaa679dbccb5107f1a9128482c). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17120: [SPARK-19715][Structured Streaming] Option to Strip Path...
Github user marmbrus commented on the issue: https://github.com/apache/spark/pull/17120 Note streams can be very long running, so this isn't about some short window. It could even be that I'm moving to a different bucket (but don't want to loose my exactly once guarantees of a very long running stream). I agree the documentation should be explicit about the expectations of the filename for this parameter. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17120: [SPARK-19715][Structured Streaming] Option to Strip Path...
Github user steveloughran commented on the issue: https://github.com/apache/spark/pull/17120 I know that's the *current* use case, but I'm thinking about future confusion, especially as the use case you espoused, "move from s3n to s3a within the same window" isn't likely to be that common in a running app, is it? At the very least, the documentation needs to be explicit about what works and what doesn't here. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17120: [SPARK-19715][Structured Streaming] Option to Strip Path...
Github user marmbrus commented on the issue: https://github.com/apache/spark/pull/17120 The use case here is when you have truly unique filenames (i.e. they contain a guid). This is actually pretty common in my experience. We definitely shouldn't turn this on by default, but as implemented I think the semantics are pretty clear and this option is useful. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17120: [SPARK-19715][Structured Streaming] Option to Strip Path...
Github user lw-lin commented on the issue: https://github.com/apache/spark/pull/17120 @steveloughran thanks for the comments. @marmbrus @zsxwing it'd be great if you could share some thoughts! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17120: [SPARK-19715][Structured Streaming] Option to Strip Path...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17120 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73691/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17120: [SPARK-19715][Structured Streaming] Option to Strip Path...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17120 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17120: [SPARK-19715][Structured Streaming] Option to Strip Path...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17120 **[Test build #73691 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73691/testReport)** for PR 17120 at commit [`aeb10d1`](https://github.com/apache/spark/commit/aeb10d100a24ca644745fb8b26985b584fd5118e). * This patch passes all tests. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * ` class SeenFilesMap(maxAgeMs: Long, fileNameOnly: Boolean) ` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17120: [SPARK-19715][Structured Streaming] Option to Strip Path...
Github user steveloughran commented on the issue: https://github.com/apache/spark/pull/17120 -1, non binding I understand the rationale for this, to aid migration from s3/s3n to s3a, but given the need is schema independence, you should be using the full path name from `Path.getUri().getPath()` instead of getName(), which means only the filename is checked. match only on name and the two files ``` s3a://bucket/incoming/dataset.avro s3a://bucket/2015/12/dataset.avro ``` will be mistaken for the same file, even when they aren't. If this scenario arises then someone will end up fielding support calls about missing data, or worse, incorrect query results. If you use the full path, that problem goes away and the filtering is only on schema and filesystem/bucket name. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17120: [SPARK-19715][Structured Streaming] Option to Strip Path...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17120 **[Test build #73691 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73691/testReport)** for PR 17120 at commit [`aeb10d1`](https://github.com/apache/spark/commit/aeb10d100a24ca644745fb8b26985b584fd5118e). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
