Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/17516
merged to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/17516
thanks, I find it rather odd but probably by design that the current
directory is different when running `R CMD check .tgz`. will need to look at
the more
---
If your project is set up for
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/17516
Got it. LGTM. Thanks for explanation. I'm fine with merging this to master !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/17516
There are two parts to the branch-2.1 fix
First, the reason why the test failed was because `SPARK_HOME` was not set
before calling `spark.install()` when running as a package. This
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/17516
The test passes even when we run the `R CMD check --as-cran` from a
different directory ? I thought the fix in `branch-2.1` was to get around that
(my understanding could be wrong)
---
If your
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/17516
The test actually passes - just not looking at the right place. Skip if
cran is not applicable in master since we are running tests as cran - if I add
skip if cran it will just disable this
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/17516
Don't we also need the skip if cran statement ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17516
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17516
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75589/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17516
**[Test build #75589 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75589/testReport)**
for PR 17516 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17516
**[Test build #75589 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75589/testReport)**
for PR 17516 at commit
11 matches
Mail list logo
