[GitHub] spark issue #17628: [SPARK-20316][SQL] Val and Var should strictly follow th...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/17628 Merged to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17628: [SPARK-20316][SQL] Val and Var should strictly follow th...
Github user ouyangxiaochen commented on the issue: https://github.com/apache/spark/pull/17628 OK, I got it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17628: [SPARK-20316][SQL] Val and Var should strictly follow th...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/17628 `"*"` does not mean what you intend -- you mean `".*"` at least, among other things. It's maybe not worth pursuing further, but that's the kind of quick check I'd expect when proposing to adjust one small instance of something. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17628: [SPARK-20316][SQL] Val and Var should strictly follow th...
Github user ouyangxiaochen commented on the issue: https://github.com/apache/spark/pull/17628 @srowen Do u mean that my regex can not match all variable name? because scala's variable name can be consisted with letter|digital|_|$? I serached the instances of `var foo="string" `with new regex `\s*var [a-z|A-Z|$|_]* = "*"` and found 33 of them. Maybe really there are no other instances. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17628: [SPARK-20316][SQL] Val and Var should strictly follow th...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/17628 @ouyangxiaochen that still isn't the right regex. Maybe there are no other instances but I'd ask for a minimal effort to find similar instances --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17628: [SPARK-20316][SQL] Val and Var should strictly follow th...
Github user viirya commented on the issue: https://github.com/apache/spark/pull/17628 I will be surprised if we find much more of this in current branch. :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17628: [SPARK-20316][SQL] val and var should strictly follow th...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17628 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75762/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17628: [SPARK-20316][SQL] val and var should strictly follow th...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17628 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17628: [SPARK-20316][SQL] val and var should strictly follow th...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17628 **[Test build #75762 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75762/testReport)** for PR 17628 at commit [`cef0405`](https://github.com/apache/spark/commit/cef04055d05a102dd1e18daad67ad35d8acd0ef5). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17628: [SPARK-20316][SQL] val and var should strictly follow th...
Github user ouyangxiaochen commented on the issue: https://github.com/apache/spark/pull/17628 OK, I'll merge such changes together into this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17628: [SPARK-20316][SQL] val and var should strictly follow th...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17628 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75759/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17628: [SPARK-20316][SQL] val and var should strictly follow th...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17628 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17628: [SPARK-20316][SQL] val and var should strictly follow th...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17628 **[Test build #75759 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75759/testReport)** for PR 17628 at commit [`32b12a0`](https://github.com/apache/spark/commit/32b12a031b56b07b47d5ffb728038f82eb0cd597). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17628: [SPARK-20316][SQL] val and var should strictly follow th...
Github user viirya commented on the issue: https://github.com/apache/spark/pull/17628 It's always good to merge such changes into one single PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17628: [SPARK-20316][SQL] val and var should strictly follow th...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17628 It is too trivial as a separate PR and I guess we don't need a JIRA for this change. I think we should find the similar instances at least (I don't think we want swarming PRs fixing such things). Also, I think we can fold https://github.com/apache/spark/pull/17629 into this here. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17628: [SPARK-20316][SQL] val and var should strictly follow th...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17628 **[Test build #75759 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75759/testReport)** for PR 17628 at commit [`32b12a0`](https://github.com/apache/spark/commit/32b12a031b56b07b47d5ffb728038f82eb0cd597). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17628: [SPARK-20316][SQL] val and var should strictly follow th...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17628 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17628: [SPARK-20316][SQL] val and var should strictly follow th...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17628 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
