Github user yssharma commented on the issue:
https://github.com/apache/spark/pull/18029
Hi, @budde , @brkyvz would love to hear your thoughts on the new patch
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18029
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18029
**[Test build #79395 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79395/testReport)**
for PR 18029 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18029
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79395/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18029
**[Test build #79395 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79395/testReport)**
for PR 18029 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18029
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79384/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18029
**[Test build #79384 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79384/testReport)**
for PR 18029 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18029
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18029
**[Test build #79384 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79384/testReport)**
for PR 18029 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18029
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79383/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18029
**[Test build #79383 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79383/testReport)**
for PR 18029 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18029
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18029
**[Test build #79383 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79383/testReport)**
for PR 18029 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18029
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79382/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18029
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18029
**[Test build #79382 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79382/testReport)**
for PR 18029 at commit
Github user yssharma commented on the issue:
https://github.com/apache/spark/pull/18029
I really appreciate you taking time to review the changes. I know balancing
work and foss contributions is difficult :)
I have given a clean new stab at the issue with all the feedbacks. Let me
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18029
**[Test build #79382 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79382/testReport)**
for PR 18029 at commit
Github user budde commented on the issue:
https://github.com/apache/spark/pull/18029
@yssharma Apologies for the slow reply-- very little of my professional dev
work happens on GitHub so I can be prone to miss things :-/
You would introduce a ```InitialPosition``` interface
Github user yssharma commented on the issue:
https://github.com/apache/spark/pull/18029
@budde @brkyvz could you suggest if the current patch seems ok, or I should
make something similar to the case class/ trait ?
---
If your project is set up for it, you can reply to this email and
Github user yssharma commented on the issue:
https://github.com/apache/spark/pull/18029
@budde What would that mean for existing applications that are sending an
`InitialPositionInStream.SOMETHING` to the the builder. We would need to
provide multiple overloaded versions of the
Github user budde commented on the issue:
https://github.com/apache/spark/pull/18029
My understanding of @brkyvz's suggestion is that you remove the two
```initialPositionInStream``` and ```initialPositionInStreamTimestamp```
arguments in favor of the single ```InitialPosition```
Github user yssharma commented on the issue:
https://github.com/apache/spark/pull/18029
Thoughts - @budde @brkyvz ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user yssharma commented on the issue:
https://github.com/apache/spark/pull/18029
For review @budde @brkyvz ^ this looks in a good state.
@brkyvz - I still didn't quite get the code bit you shared, would love to
make changes if you could explain that piece of your mind
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18029
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77796/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18029
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18029
**[Test build #77796 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77796/testReport)**
for PR 18029 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18029
**[Test build #77796 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77796/testReport)**
for PR 18029 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18029
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/5/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18029
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18029
**[Test build #5 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/5/testReport)**
for PR 18029 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18029
**[Test build #5 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/5/testReport)**
for PR 18029 at commit
Github user yssharma commented on the issue:
https://github.com/apache/spark/pull/18029
```
./bin/spark-shell --jars
/Users/ysharma/.m2/repository/org/apache/spark/spark-streaming-kinesis-asl_2.11/2.3.0-SNAPSHOT/spark-streaming-kinesis-asl_2.11-2.3.0-SNAPSHOT.jar
--packages
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18029
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18029
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77739/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18029
**[Test build #77739 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77739/testReport)**
for PR 18029 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18029
**[Test build #77739 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77739/testReport)**
for PR 18029 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18029
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77727/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18029
**[Test build #77727 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77727/testReport)**
for PR 18029 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18029
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18029
**[Test build #77727 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77727/testReport)**
for PR 18029 at commit
Github user yssharma commented on the issue:
https://github.com/apache/spark/pull/18029
@budde @brkyvz - Would appreciate if you could share some tips by which I
could include these external kinesis modules on spark-shell to test this
directly from shell (both for scala and python) ?
Github user yssharma commented on the issue:
https://github.com/apache/spark/pull/18029
@budde Added a new method to pass the timestamp more elegantly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18029
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18029
**[Test build #77726 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77726/testReport)**
for PR 18029 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18029
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77726/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18029
**[Test build #77726 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77726/testReport)**
for PR 18029 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18029
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77701/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18029
**[Test build #77701 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77701/testReport)**
for PR 18029 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18029
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18029
**[Test build #77701 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77701/testReport)**
for PR 18029 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18029
**[Test build #77700 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77700/testReport)**
for PR 18029 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18029
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77700/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18029
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18029
**[Test build #77700 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77700/testReport)**
for PR 18029 at commit
Github user yssharma commented on the issue:
https://github.com/apache/spark/pull/18029
Could I get some love here please @budde @brkyvz
This change is pretty useful for us and I would like to bake this patch
well so others can take advantage of this feature.
---
If your
Github user budde commented on the issue:
https://github.com/apache/spark/pull/18029
@yssharma I'll try to take a look later today or tomorrow
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18029
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18029
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77185/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18029
**[Test build #77185 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77185/testReport)**
for PR 18029 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18029
**[Test build #77185 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77185/testReport)**
for PR 18029 at commit
Github user yssharma commented on the issue:
https://github.com/apache/spark/pull/18029
Simplified how timestamp is passed to Kinesis for
InitialPositionInStream.AT_TIMESTAMP.
cc: @budde , @brkyvz
---
If your project is set up for it, you can reply to this email and have your
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18029
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77140/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18029
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18029
**[Test build #77140 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77140/testReport)**
for PR 18029 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18029
**[Test build #77140 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77140/testReport)**
for PR 18029 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18029
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77136/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18029
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18029
**[Test build #77136 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77136/testReport)**
for PR 18029 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18029
**[Test build #77136 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77136/testReport)**
for PR 18029 at commit
Github user yssharma commented on the issue:
https://github.com/apache/spark/pull/18029
Commit
https://github.com/apache/spark/commit/424550c8450937f78ce608ff7b18e46f41478a8a
should fix the timeouts mentioned in the
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18029
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18029
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77121/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18029
**[Test build #77121 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77121/testReport)**
for PR 18029 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18029
**[Test build #77125 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77125/testReport)**
for PR 18029 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18029
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18029
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77125/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18029
**[Test build #77125 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77125/testReport)**
for PR 18029 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18029
**[Test build #77121 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77121/testReport)**
for PR 18029 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18029
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77080/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18029
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18029
**[Test build #77080 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77080/testReport)**
for PR 18029 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18029
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77075/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18029
**[Test build #77075 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77075/testReport)**
for PR 18029 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18029
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18029
**[Test build #77075 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77075/testReport)**
for PR 18029 at commit
Github user yssharma commented on the issue:
https://github.com/apache/spark/pull/18029
@budde @brkyvz would love to hear your thoughts if this is the best way to
add this functionality
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18029
**[Test build #77043 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77043/testReport)**
for PR 18029 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18029
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18029
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77043/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18029
**[Test build #77043 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77043/testReport)**
for PR 18029 at commit
91 matches
Mail list logo
