[GitHub] spark issue #18568: [Revert][SPARK-21307][SQL] Remove SQLConf parameters fro...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18568 Thanks! Merging to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18568: [Revert][SPARK-21307][SQL] Remove SQLConf parameters fro...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18568 Since the parser is used in many places, we should still keep the original way to pass conf. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18568: [Revert][SPARK-21307][SQL] Remove SQLConf parameters fro...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18568 can we fix the active session problem? e.g. set active session in `SparkSession.sql` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18568: [Revert][SPARK-21307][SQL] Remove SQLConf parameters fro...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18568 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79348/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18568: [Revert][SPARK-21307][SQL] Remove SQLConf parameters fro...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18568 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18568: [Revert][SPARK-21307][SQL] Remove SQLConf parameters fro...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18568 **[Test build #79348 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79348/testReport)** for PR 18568 at commit [`5b579a7`](https://github.com/apache/spark/commit/5b579a7d96af02aee16c09da3d95c48d113e7b7b). * This patch passes all tests. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `class AstBuilder(conf: SQLConf) extends SqlBaseBaseVisitor[AnyRef] with Logging ` * `class CatalystSqlParser(conf: SQLConf) extends AbstractSqlParser ` * `class SparkSqlParser(conf: SQLConf) extends AbstractSqlParser ` * `class SparkSqlAstBuilder(conf: SQLConf) extends AstBuilder(conf) ` * `class VariableSubstitution(conf: SQLConf) ` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18568: [Revert][SPARK-21307][SQL] Remove SQLConf parameters fro...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18568 Will merge this after https://github.com/apache/spark/pull/18567 is merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18568: [Revert][SPARK-21307][SQL] Remove SQLConf parameters fro...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/18568 That's an unfortunate case. Sorry for missing this. :( --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18568: [Revert][SPARK-21307][SQL] Remove SQLConf parameters fro...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18568 Me too. Since setting active sessions does not work in all the cases, I believe we need to revert both PRs and then revisit them later. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18568: [Revert][SPARK-21307][SQL] Remove SQLConf parameters fro...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/18568 @gatorsmile . If then, I'm wondering the reason why SBT with Hadoop-2.6 always survives with the same configuration. I think it's not dependent on Hadoop. - https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Test%20(Dashboard)/job/spark-master-test-sbt-hadoop-2.6/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18568: [Revert][SPARK-21307][SQL] Remove SQLConf parameters fro...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18568 **[Test build #79348 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79348/testReport)** for PR 18568 at commit [`5b579a7`](https://github.com/apache/spark/commit/5b579a7d96af02aee16c09da3d95c48d113e7b7b). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
