Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18607
Could we please close this PR? Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/18607
We can just put this code in a 3rd party library, can't we? If there is an
issue with service/code discovery, we can come up with some sort of
registration process similar to the data source API.
Github user radford1 commented on the issue:
https://github.com/apache/spark/pull/18607
@gatorsmile Understood I'll work on including them.
@rxin can you help me understand this better? I was trying to add this so
spark could call Drill through jdbc. How can we include these
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/18607
Unfortunately I think drill is not popular enough to warrant inclusion in
here yet. If this is not extensible, we should make it possible to include such
mappings outside Spark and then perhaps Drill
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18607
@radford1 Yes. That is needed for merging this PR. Could you check it?
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user radford1 commented on the issue:
https://github.com/apache/spark/pull/18607
@viirya I have not had a chance to build out the docker tests like
@gatorsmile suggested. Will that be a requirement in order to merge it?
---
If your project is set up for it, you can reply to
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/18607
@radford1 Have you added the test as suggested by @gatorsmile?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user radford1 commented on the issue:
https://github.com/apache/spark/pull/18607
@viira can you review for me again please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18607
Could you also add the docker-based test suite, like what we did in
https://github.com/apache/spark/pull/9893/files?
---
If your project is set up for it, you can reply to this email and have
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18607
**[Test build #3842 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3842/testReport)**
for PR 18607 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18607
**[Test build #3842 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3842/testReport)**
for PR 18607 at commit
Github user radford1 commented on the issue:
https://github.com/apache/spark/pull/18607
I'm very new to this but was just wondering if there is anything else I
should do to help with this pull request or does it just take more time?
---
If your project is set up for it, you can
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18607
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
13 matches
Mail list logo
