[GitHub] spark issue #18897: [SPARK-21655][YARN] Support Kill CLI for Yarn mode
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/18897 Can we close this PR until #18978 is figured out? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18897: [SPARK-21655][YARN] Support Kill CLI for Yarn mode
Github user tgravescs commented on the issue: https://github.com/apache/spark/pull/18897 rpc layer split off into https://issues.apache.org/jira/browse/SPARK-21737 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18897: [SPARK-21655][YARN] Support Kill CLI for Yarn mode
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/18897 I think this RPC layer could also serve for [SPARK-19143](https://issues.apache.org/jira/browse/SPARK-19143?focusedCommentId=15815078=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15815078). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18897: [SPARK-21655][YARN] Support Kill CLI for Yarn mode
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18897 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18897: [SPARK-21655][YARN] Support Kill CLI for Yarn mode
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18897 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80496/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18897: [SPARK-21655][YARN] Support Kill CLI for Yarn mode
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18897 **[Test build #80496 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80496/testReport)** for PR 18897 at commit [`f538483`](https://github.com/apache/spark/commit/f53848391b0506f2f75a9912256ee4d348857c28). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18897: [SPARK-21655][YARN] Support Kill CLI for Yarn mode
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18897 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80494/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18897: [SPARK-21655][YARN] Support Kill CLI for Yarn mode
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18897 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18897: [SPARK-21655][YARN] Support Kill CLI for Yarn mode
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18897 **[Test build #80494 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80494/testReport)** for PR 18897 at commit [`26a92dc`](https://github.com/apache/spark/commit/26a92dc40a846e801646ac3a934faa7fc6894e0f). * This patch **fails SparkR unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18897: [SPARK-21655][YARN] Support Kill CLI for Yarn mode
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/18897 Yes, I'd really like a more thorough explanation of the RPC changes. Once that's sorted out, adding something like a "kill" command should be trivial. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18897: [SPARK-21655][YARN] Support Kill CLI for Yarn mode
Github user tgravescs commented on the issue: https://github.com/apache/spark/pull/18897 I think the kill is to more cleanly shutdown on the yarn side of things. If you yarn kill an application on yarn it doesn't set the history appropriately, etc. Its also just nice to have one spot to go to do things, similar to mapred, pig, oozie, type commands. I think we can definitely split this up into 2 prs, one for the rpc layer changes (which requires some lower level changes due to authentication with tokens) and then one for the kill command itself, does that sounds good @vanzin? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18897: [SPARK-21655][YARN] Support Kill CLI for Yarn mode
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/18897
> have the capability to safely shut down the spark application
That's not true; that works just like "yarn kill". This is the code that
does it in `DriverRunner.scala`, which is where the kill is finally processed:
```
/** Terminate this driver (or prevent it from ever starting if not yet
started) */
private[worker] def kill(): Unit = {
logInfo("Killing driver process!")
killed = true
synchronized {
process.foreach { p =>
val exitCode = Utils.terminateProcess(p,
DRIVER_TERMINATE_TIMEOUT_MS)
if (exitCode.isEmpty) {
logWarning("Failed to terminate driver process: " + p +
". This process will likely be orphaned.")
}
}
}
}
```
This change seems also way more about creating some communication channel
between arbitrary clients and the Spark AM. I'd like to see the bug and the PR
explain that in way more detail, since the "kill" implementation doesn't really
seem to be the meat of this change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18897: [SPARK-21655][YARN] Support Kill CLI for Yarn mode
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18897 **[Test build #80496 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80496/testReport)** for PR 18897 at commit [`f538483`](https://github.com/apache/spark/commit/f53848391b0506f2f75a9912256ee4d348857c28). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18897: [SPARK-21655][YARN] Support Kill CLI for Yarn mode
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18897 **[Test build #80494 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80494/testReport)** for PR 18897 at commit [`26a92dc`](https://github.com/apache/spark/commit/26a92dc40a846e801646ac3a934faa7fc6894e0f). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18897: [SPARK-21655][YARN] Support Kill CLI for Yarn mode
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18897 **[Test build #80491 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80491/testReport)** for PR 18897 at commit [`af9d7e3`](https://github.com/apache/spark/commit/af9d7e3b48e438c06ee6e948c65792aa59c95e4a). * This patch **fails Scala style tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18897: [SPARK-21655][YARN] Support Kill CLI for Yarn mode
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18897 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80491/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18897: [SPARK-21655][YARN] Support Kill CLI for Yarn mode
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18897 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18897: [SPARK-21655][YARN] Support Kill CLI for Yarn mode
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18897 **[Test build #80491 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80491/testReport)** for PR 18897 at commit [`af9d7e3`](https://github.com/apache/spark/commit/af9d7e3b48e438c06ee6e948c65792aa59c95e4a). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18897: [SPARK-21655][YARN] Support Kill CLI for Yarn mode
Github user tgravescs commented on the issue: https://github.com/apache/spark/pull/18897 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18897: [SPARK-21655][YARN] Support Kill CLI for Yarn mode
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/18897 @jerryshao Could you review this PR? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18897: [SPARK-21655][YARN] Support Kill CLI for Yarn mode
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18897 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
