Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18909
Thanks! Merging to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18909
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18909
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80598/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18909
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18909
**[Test build #80598 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80598/testReport)**
for PR 18909 at commit
Github user aokolnychyi commented on the issue:
https://github.com/apache/spark/pull/18909
@gatorsmile sure, this PR is only about tests, I was just wondering what is
planned regarding cross joins with inequality conditions.
I borrowed several tests from PR #16762 and added
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18909
**[Test build #80598 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80598/testReport)**
for PR 18909 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18909
@aokolnychyi That PR https://github.com/apache/spark/pull/16762 will not be
merged. We follow the definition of [CROSS
JOIN](http://docs.oracle.com/javadb/10.6.2.1/ref/rrefsqljcrossjoin.html).
Github user aokolnychyi commented on the issue:
https://github.com/apache/spark/pull/18909
@gatorsmile I took a look at both PRs.
I quickly scanned PR #14866 and did not find tests for existence joins.
Also, `SQLConf.CROSS_JOINS_ENABLED = true` is checked only for
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18909
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18909
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80497/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18909
**[Test build #80497 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80497/testReport)**
for PR 18909 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18909
@aokolnychyi Thank you! Could you compare the original PR and checks
whether we miss any test case you added here?
https://github.com/apache/spark/pull/14866
In addition, I also had a
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18909
**[Test build #80497 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80497/testReport)**
for PR 18909 at commit
14 matches
Mail list logo
