[GitHub] spark issue #19149: [SPARK-21652][SQL][FOLLOW-UP] Fix rule conflict between ...

2017-10-03 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19149 Actually, the root cause does not resolve by https://github.com/apache/spark/pull/19201. Will add a unit test case later. ---

[GitHub] spark issue #19149: [SPARK-21652][SQL][FOLLOW-UP] Fix rule conflict between ...

2017-09-30 Thread adrian-ionescu
Github user adrian-ionescu commented on the issue: https://github.com/apache/spark/pull/19149 At least part of the issue was solved by #19201. Unless we have a repro case, let's not pursue this. --- - To

[GitHub] spark issue #19149: [SPARK-21652][SQL][FOLLOW-UP] Fix rule conflict between ...

2017-09-29 Thread adrian-ionescu
Github user adrian-ionescu commented on the issue: https://github.com/apache/spark/pull/19149 I think the idea is good, but maybe the fix can be refined by identifying which are the rules that conflict with `InferFilterFromConstraints` and only rerunning those ones? Seems like a

[GitHub] spark issue #19149: [SPARK-21652][SQL][FOLLOW-UP] Fix rule conflict between ...

2017-09-29 Thread yhuai
Github user yhuai commented on the issue: https://github.com/apache/spark/pull/19149 Can we add a test? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19149: [SPARK-21652][SQL][FOLLOW-UP] Fix rule conflict between ...

2017-09-07 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/19149 Except that, Isolation of `InferFiltersFromConstraints` looks good to me. --- - To unsubscribe, e-mail:

[GitHub] spark issue #19149: [SPARK-21652][SQL][FOLLOW-UP] Fix rule conflict between ...

2017-09-07 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/19149 Hi, @gatorsmile . According to the PR description, it's about `PruneFilters`. Do we need a test case because SPARK-21652 is about `ConstantPropagation`, not `PruneFilters`. ---

[GitHub] spark issue #19149: [SPARK-21652][SQL][FOLLOW-UP] Fix rule conflict between ...

2017-09-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19149 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81502/ Test PASSed. ---

[GitHub] spark issue #19149: [SPARK-21652][SQL][FOLLOW-UP] Fix rule conflict between ...

2017-09-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19149 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19149: [SPARK-21652][SQL][FOLLOW-UP] Fix rule conflict between ...

2017-09-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19149 **[Test build #81502 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81502/testReport)** for PR 19149 at commit

[GitHub] spark issue #19149: [SPARK-21652][SQL][FOLLOW-UP] Fix rule conflict between ...

2017-09-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19149 **[Test build #81502 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81502/testReport)** for PR 19149 at commit

[GitHub] spark issue #19149: [SPARK-21652][SQL][FOLLOW-UP] Fix rule conflict between ...

2017-09-07 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19149 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19149: [SPARK-21652][SQL][FOLLOW-UP] Fix rule conflict between ...

2017-09-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19149 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81495/ Test FAILed. ---

[GitHub] spark issue #19149: [SPARK-21652][SQL][FOLLOW-UP] Fix rule conflict between ...

2017-09-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19149 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19149: [SPARK-21652][SQL][FOLLOW-UP] Fix rule conflict between ...

2017-09-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19149 **[Test build #81495 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81495/testReport)** for PR 19149 at commit

[GitHub] spark issue #19149: [SPARK-21652][SQL][FOLLOW-UP] Fix rule conflict between ...

2017-09-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19149 **[Test build #81495 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81495/testReport)** for PR 19149 at commit

[GitHub] spark issue #19149: [SPARK-21652][SQL][FOLLOW-UP] Fix rule conflict between ...

2017-09-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19149 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19149: [SPARK-21652][SQL][FOLLOW-UP] Fix rule conflict between ...

2017-09-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19149 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81483/ Test FAILed. ---

[GitHub] spark issue #19149: [SPARK-21652][SQL][FOLLOW-UP] Fix rule conflict between ...

2017-09-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19149 **[Test build #81483 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81483/testReport)** for PR 19149 at commit

[GitHub] spark issue #19149: [SPARK-21652][SQL][FOLLOW-UP] Fix rule conflict between ...

2017-09-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19149 **[Test build #81483 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81483/testReport)** for PR 19149 at commit