Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19389
**[Test build #84051 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84051/testReport)**
for PR 19389 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19389
I have just made a table to check the diff easily:
**Before**:
|InputA \
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19389
**[Test build #84049 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84049/testReport)**
for PR 19389 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19389
Maybe, what do you think about opening a discussion in the mailing list? If
I understood correctly, committers have a different opinion on this (did I
understand correctly?). That should
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19389
Generally, the current type inference/coercion rules are messy and random.
We have to seriously revisit our type coercion.
After thinking it more, I think this change in this PR is
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19389
Also cc @rxin @cloud-fan @sameeragarwal
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19389
Hi @gatorsmile, could you please review this when you have some time?
---
-
To unsubscribe, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19389
Thank you so much @gatorsmile.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19389
Will review it this weekend.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19389
@cloud-fan, could you take a look when you have some time please?
---
-
To unsubscribe, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19389
ping?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19389
ping @gatorsmile
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19389
Do you mean before / after in PR description? They are bugs to fix, aren't
they?
---
-
To unsubscribe, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19389
@gatorsmile, could you elaborate which behaviour changes you mean?
---
-
To unsubscribe, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19389
Please ensure no behavior change is introduced when fixing such issues.
Also cc @cloud-fan
---
-
To unsubscribe, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19389
This PR introduces the behavior changes. We are unable to do this.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19389
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82345/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19389
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19389
**[Test build #82345 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82345/testReport)**
for PR 19389 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19389
> why the tests are all going into `ParquetPartitionDiscoverySuite` -- this
doesn't seem specific to parquet, and in fact I wonder if it will be different
in parquet since the non-partition
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19389
**[Test build #82345 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82345/testReport)**
for PR 19389 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19389
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19389
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82310/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19389
**[Test build #82310 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82310/testReport)**
for PR 19389 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19389
**[Test build #82310 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82310/testReport)**
for PR 19389 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19389
**[Test build #82307 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82307/testReport)**
for PR 19389 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19389
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19389
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19389
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82307/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19389
**[Test build #82307 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82307/testReport)**
for PR 19389 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19389
cc @cloud-fan (I believe my similar PR was reviewed by you before), @ueshin
and @squito.
---
-
To unsubscribe, e-mail:
31 matches
Mail list logo
