[GitHub] spark issue #19846: [SPARK-22393][SPARK-SHELL] spark-shell can't find import...

2017-12-01 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/19846 Merged to master --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19846: [SPARK-22393][SPARK-SHELL] spark-shell can't find import...

2017-11-30 Thread mpetruska
Github user mpetruska commented on the issue: https://github.com/apache/spark/pull/19846 @HyukjinKwon : Hi, yes: this is the "retrofitting" of the original bug fix, which never made it to Scala 2.11. Instead of copy-pasting the original discussion, let me link the [original

[GitHub] spark issue #19846: [SPARK-22393][SPARK-SHELL] spark-shell can't find import...

2017-11-29 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19846 @mpetruska, btw can you fill up the PR description about how it fixes? --- - To unsubscribe, e-mail:

[GitHub] spark issue #19846: [SPARK-22393][SPARK-SHELL] spark-shell can't find import...

2017-11-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19846 **[Test build #3998 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3998/testReport)** for PR 19846 at commit

[GitHub] spark issue #19846: [SPARK-22393][SPARK-SHELL] spark-shell can't find import...

2017-11-29 Thread mpetruska
Github user mpetruska commented on the issue: https://github.com/apache/spark/pull/19846 @srowen Yes, exactly. Tried to minimize the risks of any problems caused by this change. --- - To unsubscribe, e-mail:

[GitHub] spark issue #19846: [SPARK-22393][SPARK-SHELL] spark-shell can't find import...

2017-11-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19846 **[Test build #3998 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3998/testReport)** for PR 19846 at commit

[GitHub] spark issue #19846: [SPARK-22393][SPARK-SHELL] spark-shell can't find import...

2017-11-29 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/19846 OK, so this just affects the Scala 2.11 REPL in Spark (good, because the 2.12 version works a little differently and the fix is already in 2.12), and you've just copied in the fixed classes and

[GitHub] spark issue #19846: [SPARK-22393][SPARK-SHELL] spark-shell can't find import...

2017-11-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19846 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19846: [SPARK-22393][SPARK-SHELL] spark-shell can't find import...

2017-11-29 Thread mpetruska
Github user mpetruska commented on the issue: https://github.com/apache/spark/pull/19846 Sorry, could not refactor the code better; since it makes heavy use of path-dependent types. --- - To unsubscribe, e-mail: